You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/05/10 09:15:29 UTC

[GitHub] wujimin commented on a change in pull request #698: [SCB-546] bug fix

wujimin commented on a change in pull request #698: [SCB-546] bug fix
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/698#discussion_r187279779
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
 ##########
 @@ -155,7 +155,7 @@ private boolean registerSchemas() {
         String curSchemaSumary = existSchema.getSummary();
         String schemaSummary = Hashing.sha256().newHasher().putString(content, Charsets.UTF_8).hash().toString();
         if (!schemaSummary.equals(curSchemaSumary)) {
-          if (microservice.getInstance().getEnvironment().equalsIgnoreCase("development")) {
+          if (curSchemaSumary == null || microservice.getInstance().getEnvironment().equalsIgnoreCase("development")) {
 
 Review comment:
   boolean exists = (existSchema != null) && (existSchema .getSummary() != null);

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services