You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/12/12 01:39:38 UTC
Re: Review Request 41003: Logger Module: Add the
SandboxContainerLogger, the default ContainerLogger implementation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/
-----------------------------------------------------------
(Updated Dec. 11, 2015, 4:39 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Rename from ExecutorLogger to ContainerLogger.
Summary (updated)
-----------------
Logger Module: Add the SandboxContainerLogger, the default ContainerLogger implementation.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
This implementation mirrors how executor/task stdout/stderr is currently saved to plain files.
Diffs (updated)
-----
src/slave/container_loggers/sandbox.hpp PRE-CREATION
src/slave/container_loggers/sandbox.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41003/diff/
Testing
-------
This is added to the Makefile later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41003: Logger Module: Add the
SandboxContainerLogger, the default ContainerLogger implementation.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Dec. 16, 2015, 5:23 p.m., Benjamin Hindman wrote:
> > src/slave/container_loggers/sandbox.cpp, line 55
> > <https://reviews.apache.org/r/41003/diff/6/?file=1165102#file1165102line55>
> >
> > Is this comment useful? Is there something else here you want to capture?
Removed this comment in favor of a better header-file comment.
> On Dec. 16, 2015, 5:23 p.m., Benjamin Hindman wrote:
> > src/slave/container_loggers/sandbox.cpp, line 72
> > <https://reviews.apache.org/r/41003/diff/6/?file=1165102#file1165102line72>
> >
> > Can we put a newline before this? Or:
> >
> > info.environment = environment.get({});
Changed to `getOrElse`.
> On Dec. 16, 2015, 5:23 p.m., Benjamin Hindman wrote:
> > src/slave/container_loggers/sandbox.hpp, line 44
> > <https://reviews.apache.org/r/41003/diff/6/?file=1165101#file1165101line44>
> >
> > Can we leave a comment of what this provides? And that it's the default?
Done!
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/#review110827
-----------------------------------------------------------
On Dec. 17, 2015, 12:14 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41003/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 12:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
>
>
> Bugs: MESOS-4087
> https://issues.apache.org/jira/browse/MESOS-4087
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This implementation mirrors how executor/task stdout/stderr is currently saved to plain files.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/sandbox.hpp PRE-CREATION
> src/slave/container_loggers/sandbox.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41003/diff/
>
>
> Testing
> -------
>
> This is added to the Makefile later in the review chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41003: Logger Module: Add the
SandboxContainerLogger, the default ContainerLogger implementation.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/#review110827
-----------------------------------------------------------
Ship it!
src/slave/container_loggers/sandbox.hpp (line 44)
<https://reviews.apache.org/r/41003/#comment170825>
Can we leave a comment of what this provides? And that it's the default?
src/slave/container_loggers/sandbox.cpp (line 55)
<https://reviews.apache.org/r/41003/#comment170836>
Is this comment useful? Is there something else here you want to capture?
src/slave/container_loggers/sandbox.cpp (line 72)
<https://reviews.apache.org/r/41003/#comment170832>
Can we put a newline before this? Or:
info.environment = environment.get({});
- Benjamin Hindman
On Dec. 15, 2015, 8:39 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41003/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 8:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
>
>
> Bugs: MESOS-4087
> https://issues.apache.org/jira/browse/MESOS-4087
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This implementation mirrors how executor/task stdout/stderr is currently saved to plain files.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/sandbox.hpp PRE-CREATION
> src/slave/container_loggers/sandbox.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41003/diff/
>
>
> Testing
> -------
>
> This is added to the Makefile later in the review chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41003: Logger Module: Add the
SandboxContainerLogger, the default ContainerLogger implementation.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/#review112200
-----------------------------------------------------------
Ship it!
I'll fix the indents and commit, thanks!
src/slave/container_loggers/sandbox.hpp (line 66)
<https://reviews.apache.org/r/41003/#comment172532>
No indentation here (and thus below).
src/slave/container_loggers/sandbox.cpp (line 114)
<https://reviews.apache.org/r/41003/#comment172533>
No indentation here.
- Benjamin Hindman
On Dec. 22, 2015, 12:49 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41003/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 12:49 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
>
>
> Bugs: MESOS-4087
> https://issues.apache.org/jira/browse/MESOS-4087
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This implementation mirrors how executor/task stdout/stderr is currently saved to plain files.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/sandbox.hpp PRE-CREATION
> src/slave/container_loggers/sandbox.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41003/diff/
>
>
> Testing
> -------
>
> This is added to the Makefile later in the review chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41003: Logger Module: Add the
SandboxContainerLogger, the default ContainerLogger implementation.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/
-----------------------------------------------------------
(Updated Dec. 21, 2015, 4:49 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Tweak `prepare` based on change to `SubprocessInfo`.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
This implementation mirrors how executor/task stdout/stderr is currently saved to plain files.
Diffs (updated)
-----
src/slave/container_loggers/sandbox.hpp PRE-CREATION
src/slave/container_loggers/sandbox.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41003/diff/
Testing
-------
This is added to the Makefile later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41003: Logger Module: Add the
SandboxContainerLogger, the default ContainerLogger implementation.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/
-----------------------------------------------------------
(Updated Dec. 20, 2015, 4:39 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Update sandbox implementation for changed interface.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
This implementation mirrors how executor/task stdout/stderr is currently saved to plain files.
Diffs (updated)
-----
src/slave/container_loggers/sandbox.hpp PRE-CREATION
src/slave/container_loggers/sandbox.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41003/diff/
Testing
-------
This is added to the Makefile later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41003: Logger Module: Add the
SandboxContainerLogger, the default ContainerLogger implementation.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 12:14 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Comments + tweaked one line of code.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
This implementation mirrors how executor/task stdout/stderr is currently saved to plain files.
Diffs (updated)
-----
src/slave/container_loggers/sandbox.hpp PRE-CREATION
src/slave/container_loggers/sandbox.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41003/diff/
Testing
-------
This is added to the Makefile later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41003: Logger Module: Add the
SandboxContainerLogger, the default ContainerLogger implementation.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 12:39 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Remove `options` in favor of module parameters.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
This implementation mirrors how executor/task stdout/stderr is currently saved to plain files.
Diffs (updated)
-----
src/slave/container_loggers/sandbox.hpp PRE-CREATION
src/slave/container_loggers/sandbox.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41003/diff/
Testing
-------
This is added to the Makefile later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41003: Logger Module: Add the
SandboxContainerLogger, the default ContainerLogger implementation.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 11:25 a.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Changed `options` to an `Option<string>`.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
This implementation mirrors how executor/task stdout/stderr is currently saved to plain files.
Diffs (updated)
-----
src/slave/container_loggers/sandbox.hpp PRE-CREATION
src/slave/container_loggers/sandbox.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41003/diff/
Testing
-------
This is added to the Makefile later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41003: Logger Module: Add the
SandboxContainerLogger, the default ContainerLogger implementation.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41003/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 3:46 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Update according to changed interface.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
This implementation mirrors how executor/task stdout/stderr is currently saved to plain files.
Diffs (updated)
-----
src/slave/container_loggers/sandbox.hpp PRE-CREATION
src/slave/container_loggers/sandbox.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41003/diff/
Testing
-------
This is added to the Makefile later in the review chain.
Thanks,
Joseph Wu