You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "btls1585 (via GitHub)" <gi...@apache.org> on 2026/04/03 10:56:43 UTC

[I] llm/bestpractise README uses a non-existent .env path and inconsistent API_KEY variable names [dubbo-go-pixiu-samples]

btls1585 opened a new issue, #130:
URL: https://github.com/apache/dubbo-go-pixiu-samples/issues/130

   **What happened**:
   
   The `llm/bestpractise` sample setup instructions are internally inconsistent and can easily cause the sample to fail for new users.
   
   I verified the following locally:
   
   - `README.md` and `README_zh.md` both instruct users to copy `llm/bestpractise/test/.env.example`, but that file does not exist.
   - The sample actually contains:
     - `llm/bestpractise/.env.example`
     - `llm/bestpractise/go-client/.env.example`
   - `go-client/client.go` loads `go-client/.env` and reads `API_KEY`.
   - `test/request.sh` uses `OPENAI_API_KEY` instead.
   
   Because of this, following the README literally does not produce a working environment, and the shell script and Go client expect different variable names.
   
   **What you expected to happen**:
   
   The README, go-client/client.go, and `test/request.sh` should use consistent setup instructions, correct `.env` paths, and consistent API key variable naming.
   
   **How to reproduce it (as minimally and precisely as possible)**:
   
   1. Open `llm/bestpractise/README.md` or `README_zh.md`.
   2. Follow the documented step that copies `llm/bestpractise/test/.env.example`.
   3. Check the repository contents:
      - `llm/bestpractise/test/.env.example` does not exist.
      - `llm/bestpractise/go-client/.env.example` does exist.
   4. Check `go-client/client.go`: it reads `go-client/.env` and uses `API_KEY`.
   5. Check `test/request.sh`: it uses `OPENAI_API_KEY`.
   
   **Anything else we need to know?**:
   
   I reproduced this locally while running the `llm/bestpractise` sample.
   
   Relevant files:
   - `llm/bestpractise/README.md`
   - `llm/bestpractise/README_zh.md`
   - `llm/bestpractise/go-client/client.go`
   - `llm/bestpractise/test/request.sh`
   - `llm/bestpractise/go-client/.env.example`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

Re: [I] llm/bestpractise README uses a non-existent .env path and inconsistent API_KEY variable names [dubbo-go-pixiu-samples]

Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl closed issue #130: llm/bestpractise README uses a non-existent .env path and inconsistent API_KEY variable names
URL: https://github.com/apache/dubbo-go-pixiu-samples/issues/130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org