You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/05/20 03:50:32 UTC
Review Request 21675: Fixed ExternalContainerizer Subprocess use for non
sandboxed invocations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21675/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
When using Subprocess on non sandboxed invocations of the external containerizer program, stderr was not getting redirected at all, possibly triggering deadlocks due to a filled stderr pipe that was not getting drained. This patch redirects to /dev/null when no sandbox is given for an invocation. See MESOS-1336.
Diffs
-----
src/slave/containerizer/external_containerizer.cpp f9811c4
Diff: https://reviews.apache.org/r/21675/diff/
Testing
-------
make check (on upcoming test suite)
Thanks,
Till Toenshoff
Re: Review Request 21675: Fixed ExternalContainerizer Subprocess use for non
sandboxed invocations.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21675/#review43698
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On May 19, 2014, 6:50 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21675/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 6:50 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> When using Subprocess on non sandboxed invocations of the external containerizer program, stderr was not getting redirected at all, possibly triggering deadlocks due to a filled stderr pipe that was not getting drained. This patch redirects to /dev/null when no sandbox is given for an invocation. See MESOS-1336.
>
>
> Diffs
> -----
>
> src/slave/containerizer/external_containerizer.cpp f9811c4
>
> Diff: https://reviews.apache.org/r/21675/diff/
>
>
> Testing
> -------
>
> make check (on upcoming test suite)
>
>
> Thanks,
>
> Till Toenshoff
>
>