You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/05/20 07:04:20 UTC
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin opened a new pull request #83: SLING-10401 change scope to 'compile' to not hide dependencies for
kwin opened a new pull request #83:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/83
upstream consumers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #83: SLING-10401 change scope to 'compile' to not hide dependencies for
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #83:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/83#issuecomment-844773605
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=83&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls merged pull request #83: SLING-10401 change scope to 'compile' to not hide dependencies for
Posted by GitBox <gi...@apache.org>.
karlpauls merged pull request #83:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #83: SLING-10401 change scope to 'compile' to not hide dependencies for
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #83:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/83#issuecomment-846039039
Compare also with the long discussion in https://issues.apache.org/jira/browse/MNG-2205. IMHO using `provided` is just plain wrong for dependencies of simple JARs which are not supposed to be used in OSGi context or a servlet container. I think the approach from https://issues.apache.org/jira/browse/MNG-2205?focusedCommentId=15150313&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15150313 is reasonable and that is what I did in this PR. I fail to see how this could introduce regressions....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin edited a comment on pull request #83: SLING-10401 change scope to 'compile' to not hide dependencies for
Posted by GitBox <gi...@apache.org>.
kwin edited a comment on pull request #83:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/83#issuecomment-844775559
> What problem does this solve?
https://github.com/adobe/aemanalyser-maven-plugin/issues/58
For changing versions you use `dependencyManagement`. But the downstream consumers should only be forced to declare those dependencies they use directly not transitively!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] cziegeler commented on pull request #83: SLING-10401 change scope to 'compile' to not hide dependencies for
Posted by GitBox <gi...@apache.org>.
cziegeler commented on pull request #83:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/83#issuecomment-844774479
What problem does this solve? Doesn't make it harder for downstream users to use different versions of the libraries in combination with the converter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin edited a comment on pull request #83: SLING-10401 change scope to 'compile' to not hide dependencies for
Posted by GitBox <gi...@apache.org>.
kwin edited a comment on pull request #83:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/83#issuecomment-844775559
For changing versions you use `dependencyManagement`. But the downstream consumers should only be forced to declare those dependencies they use directly not transitively!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #83: SLING-10401 change scope to 'compile' to not hide dependencies for
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #83:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/83#issuecomment-844775559
For changing versions you use `dependencyManagement`. But the downstream consumers should only declare those dependencies they use directly not transitively!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] cziegeler commented on pull request #83: SLING-10401 change scope to 'compile' to not hide dependencies for
Posted by GitBox <gi...@apache.org>.
cziegeler commented on pull request #83:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/83#issuecomment-846049100
I don't think that there is a right or a wrong approach here - every approach has its benefits. We can have long debates over it and will most likely not agree at the end. So if you think this is the way forward, please do so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org