You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "XenoAmess (via GitHub)" <gi...@apache.org> on 2023/03/06 14:25:01 UTC
[GitHub] [commons-compress] XenoAmess opened a new pull request, #365: add getLinkFlag for TarArchiveEntry
XenoAmess opened a new pull request, #365:
URL: https://github.com/apache/commons-compress/pull/365
Hi.
I'm making a somehow like tar compressing tool.
And I need to know what the original flag of a tar entry I read, otherwise I would make it changed in the decompressed result...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] XenoAmess commented on pull request #365: COMPRESS-641: add getLinkFlag for TarArchiveEntry
Posted by "XenoAmess (via GitHub)" <gi...@apache.org>.
XenoAmess commented on PR #365:
URL: https://github.com/apache/commons-compress/pull/365#issuecomment-1456377682
> @XenoAmess are you going to retrieve the `linkFlag` byte value, and then compare doing something like `if (linkFlag == SOME_CONSTANT) {} else if (linkFlag == ANOTHER_CONSTANT) { ... }` ?
>
> If so, would it be possible to instead use the public methods like `if (obj.isBlockDevice())`, `else if (obj.isCharacterDevice())`, etc., instead?
>
> Just checking if there's no alternative to making this property public.
>
> Cheers,
>
> -Bruno
no, I would put it directly into the output tar
the mechenism of my compression is only compress entries with some linkFlag types.
for others, just make them same and clone them directly into the output compressed tar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] codecov-commenter commented on pull request #365: COMPRESS-641: add getLinkFlag for TarArchiveEntry
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #365:
URL: https://github.com/apache/commons-compress/pull/365#issuecomment-1458915640
# [Codecov](https://codecov.io/gh/apache/commons-compress/pull/365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#365](https://codecov.io/gh/apache/commons-compress/pull/365?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9014fb1) into [master](https://codecov.io/gh/apache/commons-compress/commit/1ae202155c56fe0bdae3e2a9b63f6bb7d192cc2c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ae2021) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #365 +/- ##
=========================================
Coverage 80.43% 80.44%
- Complexity 6723 6725 +2
=========================================
Files 343 343
Lines 25330 25331 +1
Branches 4106 4106
=========================================
+ Hits 20374 20377 +3
+ Misses 3371 3368 -3
- Partials 1585 1586 +1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-compress/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ommons/compress/archivers/tar/TarArchiveEntry.java](https://codecov.io/gh/apache/commons-compress/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvYXJjaGl2ZXJzL3Rhci9UYXJBcmNoaXZlRW50cnkuamF2YQ==) | `71.76% <100.00%> (+0.05%)` | :arrow_up: |
| [.../commons/compress/compressors/bzip2/BlockSort.java](https://codecov.io/gh/apache/commons-compress/pull/365?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvY29tcHJlc3NvcnMvYnppcDIvQmxvY2tTb3J0LmphdmE=) | `84.90% <0.00%> (+0.47%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] garydgregory merged pull request #365: COMPRESS-641: add getLinkFlag for TarArchiveEntry
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #365:
URL: https://github.com/apache/commons-compress/pull/365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] kinow commented on pull request #365: COMPRESS-641: add getLinkFlag for TarArchiveEntry
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #365:
URL: https://github.com/apache/commons-compress/pull/365#issuecomment-1458153863
> Adding the getter seems reasonable to me as it is documented here if I am reading correctly: https://www.gnu.org/software/tar/manual/html_node/Standard.html
Yeah, I was trying to think in other ways to solve what @XenoAmess needed without adding that getter (as there are other properties that are private only, without getters), but I can't think of an alternative. So +1 to the getter too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] garydgregory commented on pull request #365: COMPRESS-641: add getLinkFlag for TarArchiveEntry
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #365:
URL: https://github.com/apache/commons-compress/pull/365#issuecomment-1457114819
Adding the getter seems reasonable to me as it is documented here if I am reading correctly: https://www.gnu.org/software/tar/manual/html_node/Standard.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] XenoAmess commented on pull request #365: COMPRESS-641: add getLinkFlag for TarArchiveEntry
Posted by "XenoAmess (via GitHub)" <gi...@apache.org>.
XenoAmess commented on PR #365:
URL: https://github.com/apache/commons-compress/pull/365#issuecomment-1458961029
> Just needs to squash commits. Otherwise, looks good to me! Thanks @XenoAmess !
@kinow squashed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] XenoAmess commented on pull request #365: COMPRESS-641: add getLinkFlag for TarArchiveEntry
Posted by "XenoAmess (via GitHub)" <gi...@apache.org>.
XenoAmess commented on PR #365:
URL: https://github.com/apache/commons-compress/pull/365#issuecomment-1456381061
> -1: Javadoc is completely wrong; no unit test.
javadoc fixed.
Would add unit test, but I want to know about your opinons about exposing such a field first.
If made sure you don't mind we expose it, then I would add the unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] XenoAmess commented on pull request #365: COMPRESS-641: add getLinkFlag for TarArchiveEntry
Posted by "XenoAmess (via GitHub)" <gi...@apache.org>.
XenoAmess commented on PR #365:
URL: https://github.com/apache/commons-compress/pull/365#issuecomment-1458930276
@garydgregory
unit tests added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org