[GitHub] JoelB commented on a change in pull request #371: GUACAMOLE-717: Handle LDAPException gracefully when doing a search

[GitBox <gi...@apache.org>]

JoelB commented on a change in pull request #371: GUACAMOLE-717: Handle LDAPException gracefully when doing a search
URL: https://github.com/apache/guacamole-client/pull/371#discussion_r251168422
 
 

 ##########
 File path: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
 ##########
 @@ -220,6 +220,9 @@ public String generateQuery(String filter,
                         logger.warn("Given a referral, but referrals are disabled. Error was: {}", e.getMessage());
                         logger.debug("Got a referral, but configured to not follow them.", e);
                     }
+                } catch (LDAPException e) {
+                  logger.warn("Failed to process an LDAP search result.");
+                  logger.error("Error processing LDAPEntry search result.",e);
 
 Review comment:
   Oops, I meant for that to be in the debug logs. The warning should be sufficient to point the admin in the right direction.  I've moved the stack trace to debug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services