[jira] [Commented] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

["Neha Narkhede (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154867#comment-14154867 ] 

Neha Narkhede commented on KAFKA-1634:
--------------------------------------

[~jjkoshy] Thanks for the explanation. If retention is the use case, it is easier to understand if it was called retentionPeriod. Since 0.8.2 is when this releases, it will be great to make that renaming change before 0.8.2 goes out. If there is a broker side feature that is required for this to work properly and it's not done, then we can either get rid of this and add it when it's useful or leave it in there as a no-op or with a warning. What do you prefer?

> Update protocol wiki to reflect the new offset management feature
> -----------------------------------------------------------------
>
>                 Key: KAFKA-1634
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1634
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Neha Narkhede
>            Assignee: Jun Rao
>            Priority: Blocker
>             Fix For: 0.8.2
>
>
> From the mailing list -
> following up on this -- I think the online API docs for OffsetCommitRequest
> still incorrectly refer to client-side timestamps:
> https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-OffsetCommitRequest
> Wasn't that removed and now always handled server-side now?  Would one of
> the devs mind updating the API spec wiki?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)