You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by "aleksey zhukov (JIRA)" <ji...@apache.org> on 2009/06/02 18:19:07 UTC
[jira] Created: (IVY-1087) ivy:resolve ignores branch in "dynamic"
resolve mode
ivy:resolve ignores branch in "dynamic" resolve mode
----------------------------------------------------
Key: IVY-1087
URL: https://issues.apache.org/jira/browse/IVY-1087
Project: Ivy
Issue Type: Bug
Components: Core
Affects Versions: 2.1.0-RC1
Environment: Linux 2.6.18-92.1.22.el5 #1 SMP Tue Dec 16 12:03:43 EST 2008 i686 athlon i386 GNU/Linux
Reporter: aleksey zhukov
Priority: Critical
When I call ivy:resolve as following
<ivy:resolve file="${deps.file}" showProgress="false" conf="compile" resolveMode="dynamic"/>
and having
<ivy pattern="${ivy.local.default.root}/[organisation]/[branch]/[module]-ivys/ivy-[revision].xml"/>
<artifact pattern="${ivy.local.default.root}/[organisation]/[branch]/[artifact]-[revision].[ext]"/>
set in my defaultResolver
ivy:resolver ignores [branch] and looks for ivy.xml in "${ivy.local.default.root}/[organisation]//[module]-ivys/ivy-[revision].xml"
and artifact in "${ivy.local.default.root}/[organisation]//[artifact]-[revision].[ext]".
However if I call <ivy:resolve file="${deps.file}" showProgress="false" conf="compile"/> without resolveMode set, everything is fine and resolve follows [organisation]/[branch] path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (IVY-1087) ivy:resolve ignores branch in "dynamic"
resolve mode
Posted by "aleksey zhukov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
aleksey zhukov closed IVY-1087.
-------------------------------
Thanks, it works.
> ivy:resolve ignores branch in "dynamic" resolve mode
> ----------------------------------------------------
>
> Key: IVY-1087
> URL: https://issues.apache.org/jira/browse/IVY-1087
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC1
> Environment: Linux 2.6.18-92.1.22.el5 #1 SMP Tue Dec 16 12:03:43 EST 2008 i686 athlon i386 GNU/Linux
> Reporter: aleksey zhukov
> Assignee: Maarten Coene
> Priority: Blocker
> Fix For: 2.1.0-RC2
>
>
> When I call ivy:resolve as following
> <ivy:resolve file="${deps.file}" showProgress="false" conf="compile" resolveMode="dynamic"/>
> and having
> <ivy pattern="${ivy.local.default.root}/[organisation]/[branch]/[module]-ivys/ivy-[revision].xml"/>
> <artifact pattern="${ivy.local.default.root}/[organisation]/[branch]/[artifact]-[revision].[ext]"/>
> set in my defaultResolver
> ivy:resolver ignores [branch] and looks for ivy.xml in "${ivy.local.default.root}/[organisation]//[module]-ivys/ivy-[revision].xml"
> and artifact in "${ivy.local.default.root}/[organisation]//[artifact]-[revision].[ext]".
> However if I call <ivy:resolve file="${deps.file}" showProgress="false" conf="compile"/> without resolveMode set, everything is fine and resolve follows [organisation]/[branch] path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (IVY-1087) ivy:resolve ignores branch in "dynamic"
resolve mode
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene reopened IVY-1087:
--------------------------------
Now that I think of it a bit further, I'm not sure that my commit will change anything...
Please feel free to give it a try, but I'm reopening it for further investigation.
> ivy:resolve ignores branch in "dynamic" resolve mode
> ----------------------------------------------------
>
> Key: IVY-1087
> URL: https://issues.apache.org/jira/browse/IVY-1087
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC1
> Environment: Linux 2.6.18-92.1.22.el5 #1 SMP Tue Dec 16 12:03:43 EST 2008 i686 athlon i386 GNU/Linux
> Reporter: aleksey zhukov
> Assignee: Maarten Coene
> Priority: Blocker
> Fix For: trunk
>
>
> When I call ivy:resolve as following
> <ivy:resolve file="${deps.file}" showProgress="false" conf="compile" resolveMode="dynamic"/>
> and having
> <ivy pattern="${ivy.local.default.root}/[organisation]/[branch]/[module]-ivys/ivy-[revision].xml"/>
> <artifact pattern="${ivy.local.default.root}/[organisation]/[branch]/[artifact]-[revision].[ext]"/>
> set in my defaultResolver
> ivy:resolver ignores [branch] and looks for ivy.xml in "${ivy.local.default.root}/[organisation]//[module]-ivys/ivy-[revision].xml"
> and artifact in "${ivy.local.default.root}/[organisation]//[artifact]-[revision].[ext]".
> However if I call <ivy:resolve file="${deps.file}" showProgress="false" conf="compile"/> without resolveMode set, everything is fine and resolve follows [organisation]/[branch] path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (IVY-1087) ivy:resolve ignores branch in "dynamic"
resolve mode
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene resolved IVY-1087.
--------------------------------
Resolution: Fixed
ok, I've committed another change which I hope will fix the problem.
Please give it a try and post your feedback here.
Maarten
> ivy:resolve ignores branch in "dynamic" resolve mode
> ----------------------------------------------------
>
> Key: IVY-1087
> URL: https://issues.apache.org/jira/browse/IVY-1087
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC1
> Environment: Linux 2.6.18-92.1.22.el5 #1 SMP Tue Dec 16 12:03:43 EST 2008 i686 athlon i386 GNU/Linux
> Reporter: aleksey zhukov
> Assignee: Maarten Coene
> Priority: Blocker
> Fix For: trunk
>
>
> When I call ivy:resolve as following
> <ivy:resolve file="${deps.file}" showProgress="false" conf="compile" resolveMode="dynamic"/>
> and having
> <ivy pattern="${ivy.local.default.root}/[organisation]/[branch]/[module]-ivys/ivy-[revision].xml"/>
> <artifact pattern="${ivy.local.default.root}/[organisation]/[branch]/[artifact]-[revision].[ext]"/>
> set in my defaultResolver
> ivy:resolver ignores [branch] and looks for ivy.xml in "${ivy.local.default.root}/[organisation]//[module]-ivys/ivy-[revision].xml"
> and artifact in "${ivy.local.default.root}/[organisation]//[artifact]-[revision].[ext]".
> However if I call <ivy:resolve file="${deps.file}" showProgress="false" conf="compile"/> without resolveMode set, everything is fine and resolve follows [organisation]/[branch] path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1087) ivy:resolve ignores branch in "dynamic"
resolve mode
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene updated IVY-1087:
-------------------------------
Fix Version/s: (was: trunk)
2.1.0-RC2
> ivy:resolve ignores branch in "dynamic" resolve mode
> ----------------------------------------------------
>
> Key: IVY-1087
> URL: https://issues.apache.org/jira/browse/IVY-1087
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC1
> Environment: Linux 2.6.18-92.1.22.el5 #1 SMP Tue Dec 16 12:03:43 EST 2008 i686 athlon i386 GNU/Linux
> Reporter: aleksey zhukov
> Assignee: Maarten Coene
> Priority: Blocker
> Fix For: 2.1.0-RC2
>
>
> When I call ivy:resolve as following
> <ivy:resolve file="${deps.file}" showProgress="false" conf="compile" resolveMode="dynamic"/>
> and having
> <ivy pattern="${ivy.local.default.root}/[organisation]/[branch]/[module]-ivys/ivy-[revision].xml"/>
> <artifact pattern="${ivy.local.default.root}/[organisation]/[branch]/[artifact]-[revision].[ext]"/>
> set in my defaultResolver
> ivy:resolver ignores [branch] and looks for ivy.xml in "${ivy.local.default.root}/[organisation]//[module]-ivys/ivy-[revision].xml"
> and artifact in "${ivy.local.default.root}/[organisation]//[artifact]-[revision].[ext]".
> However if I call <ivy:resolve file="${deps.file}" showProgress="false" conf="compile"/> without resolveMode set, everything is fine and resolve follows [organisation]/[branch] path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1087) ivy:resolve ignores branch in "dynamic"
resolve mode
Posted by "aleksey zhukov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
aleksey zhukov updated IVY-1087:
--------------------------------
Priority: Blocker (was: Critical)
Can someone look at this, please?
It is a truly blocker for me.
> ivy:resolve ignores branch in "dynamic" resolve mode
> ----------------------------------------------------
>
> Key: IVY-1087
> URL: https://issues.apache.org/jira/browse/IVY-1087
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC1
> Environment: Linux 2.6.18-92.1.22.el5 #1 SMP Tue Dec 16 12:03:43 EST 2008 i686 athlon i386 GNU/Linux
> Reporter: aleksey zhukov
> Priority: Blocker
>
> When I call ivy:resolve as following
> <ivy:resolve file="${deps.file}" showProgress="false" conf="compile" resolveMode="dynamic"/>
> and having
> <ivy pattern="${ivy.local.default.root}/[organisation]/[branch]/[module]-ivys/ivy-[revision].xml"/>
> <artifact pattern="${ivy.local.default.root}/[organisation]/[branch]/[artifact]-[revision].[ext]"/>
> set in my defaultResolver
> ivy:resolver ignores [branch] and looks for ivy.xml in "${ivy.local.default.root}/[organisation]//[module]-ivys/ivy-[revision].xml"
> and artifact in "${ivy.local.default.root}/[organisation]//[artifact]-[revision].[ext]".
> However if I call <ivy:resolve file="${deps.file}" showProgress="false" conf="compile"/> without resolveMode set, everything is fine and resolve follows [organisation]/[branch] path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (IVY-1087) ivy:resolve ignores branch in "dynamic"
resolve mode
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene resolved IVY-1087.
--------------------------------
Resolution: Fixed
Fix Version/s: trunk
Assignee: Maarten Coene
Thanks for the patch,
I've committed a slightly modified version of it, could you please give it a try and post your feedback here?
thanks,
Maarten
> ivy:resolve ignores branch in "dynamic" resolve mode
> ----------------------------------------------------
>
> Key: IVY-1087
> URL: https://issues.apache.org/jira/browse/IVY-1087
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC1
> Environment: Linux 2.6.18-92.1.22.el5 #1 SMP Tue Dec 16 12:03:43 EST 2008 i686 athlon i386 GNU/Linux
> Reporter: aleksey zhukov
> Assignee: Maarten Coene
> Priority: Blocker
> Fix For: trunk
>
>
> When I call ivy:resolve as following
> <ivy:resolve file="${deps.file}" showProgress="false" conf="compile" resolveMode="dynamic"/>
> and having
> <ivy pattern="${ivy.local.default.root}/[organisation]/[branch]/[module]-ivys/ivy-[revision].xml"/>
> <artifact pattern="${ivy.local.default.root}/[organisation]/[branch]/[artifact]-[revision].[ext]"/>
> set in my defaultResolver
> ivy:resolver ignores [branch] and looks for ivy.xml in "${ivy.local.default.root}/[organisation]//[module]-ivys/ivy-[revision].xml"
> and artifact in "${ivy.local.default.root}/[organisation]//[artifact]-[revision].[ext]".
> However if I call <ivy:resolve file="${deps.file}" showProgress="false" conf="compile"/> without resolveMode set, everything is fine and resolve follows [organisation]/[branch] path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1087) ivy:resolve ignores branch in
"dynamic" resolve mode
Posted by "aleksey zhukov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723754#action_12723754 ]
aleksey zhukov commented on IVY-1087:
-------------------------------------
OK, I have fixed that. Please review the patch.
diff -up ./XmlModuleDescriptorParser.java.orig ./XmlModuleDescriptorParser.java
--- ./XmlModuleDescriptorParser.java.orig 2009-06-24 13:15:54.000000000 -0500
+++ ./XmlModuleDescriptorParser.java 2009-06-24 12:12:58.000000000 -0500
@@ -521,6 +521,8 @@ public class XmlModuleDescriptorParser e
String name = settings.substitute(attributes.getValue("name"));
String branch = settings.substitute(attributes.getValue("branch"));
String branchConstraint = settings.substitute(attributes.getValue("branchConstraint"));
+ branchConstraint = branchConstraint == null ? branch : branchConstraint;
+
String rev = settings.substitute(attributes.getValue("rev"));
String revConstraint = settings.substitute(attributes.getValue("revConstraint"));
revConstraint = revConstraint == null ? rev : revConstraint;
If this is ok, please add it to the trunk.
> ivy:resolve ignores branch in "dynamic" resolve mode
> ----------------------------------------------------
>
> Key: IVY-1087
> URL: https://issues.apache.org/jira/browse/IVY-1087
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC1
> Environment: Linux 2.6.18-92.1.22.el5 #1 SMP Tue Dec 16 12:03:43 EST 2008 i686 athlon i386 GNU/Linux
> Reporter: aleksey zhukov
> Priority: Blocker
>
> When I call ivy:resolve as following
> <ivy:resolve file="${deps.file}" showProgress="false" conf="compile" resolveMode="dynamic"/>
> and having
> <ivy pattern="${ivy.local.default.root}/[organisation]/[branch]/[module]-ivys/ivy-[revision].xml"/>
> <artifact pattern="${ivy.local.default.root}/[organisation]/[branch]/[artifact]-[revision].[ext]"/>
> set in my defaultResolver
> ivy:resolver ignores [branch] and looks for ivy.xml in "${ivy.local.default.root}/[organisation]//[module]-ivys/ivy-[revision].xml"
> and artifact in "${ivy.local.default.root}/[organisation]//[artifact]-[revision].[ext]".
> However if I call <ivy:resolve file="${deps.file}" showProgress="false" conf="compile"/> without resolveMode set, everything is fine and resolve follows [organisation]/[branch] path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.