[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #6618: [DS-6606] [fix] [common] JSONUtils#getNodeString String type #6606

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #6618:
URL: https://github.com/apache/dolphinscheduler/pull/6618#discussion_r738047407



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java
##########
@@ -212,26 +208,28 @@ public static String findValue(JsonNode jsonNode, String fieldName) {
     }
 
     /**
-     * json to map
-     * {@link #toMap(String, Class, Class)}
+     * json to map {@link #toMap(String, Class, Class)}
      *
      * @param json json
      * @return json to map
      */
     public static Map<String, String> toMap(String json) {
-        return parseObject(json, new TypeReference<Map<String, String>>() {});
+        return parseObject(json, new TypeReference<Map<String, String>>() {
+        });
     }
 
     /**
      * from the key-value generated json  to get the str value no matter the real type of value
-     * @param json the json str
+     *
+     * @param json     the json str
      * @param nodeName key
      * @return the str value of key
      */
     public static String getNodeString(String json, String nodeName) {

Review comment:
       I still suggest deleting this method, this is not used now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org