[jira] [Commented] (HBASE-15486) Avoid multiple disable/enable balancer calls while running rolling-restart.sh --graceful

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206313#comment-15206313 ] 

Hadoop QA commented on HBASE-15486:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 6s {color} | {color:red} The applied patch generated 6 new + 416 unchanged - 2 fixed = 422 total (was 418) {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 3s {color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 59m 7s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 42s {color} | {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 60m 25s {color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12794747/HBASE-15486_v0.patch |
| JIRA Issue | HBASE-15486 |
| Optional Tests |  asflicense  shellcheck  shelldocs  |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh |
| git revision | master / 797562e |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider upgrading.) |
| shellcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/1136/artifact/patchprocess/diff-patch-shellcheck.txt |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1136/console |
| Powered by | Apache Yetus 0.2.0   http://yetus.apache.org |


This message was automatically generated.



> Avoid multiple disable/enable balancer calls while running rolling-restart.sh --graceful 
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-15486
>                 URL: https://issues.apache.org/jira/browse/HBASE-15486
>             Project: HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 2.0.0, 1.1.4, 1.0.4
>            Reporter: Samir Ahmic
>            Assignee: Samir Ahmic
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15486_v0.patch
>
>
> When running rolling-restart.sh --graceful we are using graceful_stop.sh to unload/restart/load regionserver. For every restarted  regionserver  we are making two calls in graceful-stop.sh to hbase shell to disable/enable balancer. This means if we have 100 regionservers to restart by rolling-restart.sh --graceful we will make 200 calls to hbase shell. Instead i propose that we add optional parameter in graceful_stop.sh that will tell script not to manage balancer and manage balancer states in rolling-restart.sh when running with --graceful parameter. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)