You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/11/08 15:37:15 UTC
[GitHub] [cassandra] smiklosovic opened a new pull request, #1990: CASSANDRA-17964 ant trunk
smiklosovic opened a new pull request, #1990:
URL: https://github.com/apache/cassandra/pull/1990
patch by Stefan Miklosovic; reviewed by Berenguer Blasi and David Capwell for CASSANDRA-17943
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085377886
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -0,0 +1,85 @@
+/*
Review Comment:
@michaelsembwever the check implementation uses `org.junit.Test` annotation to scan test methods. org.junit.Test is on test class path and that annotation is not part of runtime classpath.
We would have to have special class path just for ant tasks with test classpath as well? I wonder what that is in practice good for. Lets keep it like it is?
Also I think that we need to have access to these test classes to scan etc so test class path is a must, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085341743
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -0,0 +1,85 @@
+/*
Review Comment:
given this is for tests I believe it is most suitable to put it among test sources, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085352633
##########
build.xml:
##########
@@ -1027,6 +1028,22 @@
</copy>
</target>
+ <macrodef name="checktestnameshelper">
+ <sequential>
+ <taskdef name="test-name-check_" classname="org.apache.cassandra.anttasks.TestNameCheckTask" classpath="${test.classes}">
+ <classpath>
+ <path refid="cassandra.classpath.test"/>
+ <path location="${fqltool.build.classes}"/>
+ </classpath>
+ </taskdef>
+ <test-name-check_/>
+ </sequential>
+ </macrodef>
+
+ <target name="check-test-names" depends="_main-jar,stress-build,fqltool-build,resolver-dist-lib,simulator-jars,_build-test">
+ <checktestnameshelper/>
+ </target>
Review Comment:
YAGNI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085377886
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -0,0 +1,85 @@
+/*
Review Comment:
@michaelsembwever the check implementation uses `org.junit.Test` annotation to scan test methods. org.junit.Test is on test class path and that annotation is not part of runtime classpath.
We would have to have special class path just for ant tasks with test classpath as well? I wonder what that is in practice good for. Lets keep it like it is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085377886
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -0,0 +1,85 @@
+/*
Review Comment:
@michaelsembwever the check implementation uses `org.junit.Test` annotation to scan test methods. org.junit.Test is on test class path and that annotation is not part of runtime classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085398175
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -0,0 +1,85 @@
+/*
Review Comment:
> We would have to have special class path just for ant tasks with test classpath as well?
No. ant tasks are already their own compilation path with its own classpath. Thinking about it as runtime or test is wrong, it's more bootstrap than anything else. (It doesn't matter that the class itself uses org.junit.Test)
> Also I think that we need to have access to these test classes to scan etc so test class path is a must, no?
No. That's just runtime configuration of the ant task. (The ant task class doesn't need that classpath to compile.)
Moving all of the anttask folder to a new location is out-of-scope for this PR. But I still think it is the right thing to do (at a later point).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085390876
##########
build.xml:
##########
@@ -1027,6 +1028,22 @@
</copy>
</target>
+ <macrodef name="checktestnameshelper">
+ <sequential>
+ <taskdef name="test-name-check_" classname="org.apache.cassandra.anttasks.TestNameCheckTask" classpath="${test.classes}">
+ <classpath>
+ <path refid="cassandra.classpath.test"/>
+ <path location="${fqltool.build.classes}"/>
+ </classpath>
+ </taskdef>
+ <test-name-check_/>
+ </sequential>
+ </macrodef>
+
+ <target name="check-test-names" depends="_main-jar,stress-build,fqltool-build,resolver-dist-lib,simulator-jars,_build-test">
+ <checktestnameshelper/>
+ </target>
Review Comment:
I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085356008
##########
build.xml:
##########
@@ -1027,6 +1028,22 @@
</copy>
</target>
+ <macrodef name="checktestnameshelper">
+ <sequential>
+ <taskdef name="test-name-check_" classname="org.apache.cassandra.anttasks.TestNameCheckTask" classpath="${test.classes}">
+ <classpath>
+ <path refid="cassandra.classpath.test"/>
+ <path location="${fqltool.build.classes}"/>
+ </classpath>
+ </taskdef>
+ <test-name-check_/>
+ </sequential>
+ </macrodef>
Review Comment:
@michaelsembwever I would really keep this as is. Please keep in mind this goes to 5 branches already and each branch is little bit different etc. I am spending a lot of time on merging this up from 3.0. I think what you suggested might be explored but I would really reserve this work for another ticket with all other checkstyle targets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085351069
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -0,0 +1,85 @@
+/*
Review Comment:
i was thinking about all the anttasks classes. they are not part of the tests classpath, or the runtime classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085361871
##########
build.xml:
##########
@@ -1027,6 +1028,22 @@
</copy>
</target>
+ <macrodef name="checktestnameshelper">
+ <sequential>
+ <taskdef name="test-name-check_" classname="org.apache.cassandra.anttasks.TestNameCheckTask" classpath="${test.classes}">
+ <classpath>
+ <path refid="cassandra.classpath.test"/>
+ <path location="${fqltool.build.classes}"/>
+ </classpath>
+ </taskdef>
+ <test-name-check_/>
+ </sequential>
+ </macrodef>
Review Comment:
fine by me. (i'd appreciate in time all the help i can get to better encapsulate the ant xml, and standardise how we do skip flags)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085437458
##########
ide/idea-iml-file.xml:
##########
@@ -30,6 +30,7 @@
<sourceFolder url="file://$MODULE_DIR$/tools/stress/test/unit" isTestSource="true" />
<sourceFolder url="file://$MODULE_DIR$/tools/fqltool/src" isTestSource="false" />
<sourceFolder url="file://$MODULE_DIR$/tools/fqltool/test/unit" isTestSource="true" />
+ <sourceFolder url="file://$MODULE_DIR$/test/anttasks" isTestSource="true" />
Review Comment:
@michaelsembwever you know what ... I will remove this from IDEA. If we plan to extract it all from `test`, this seems like unnecessary exercise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085344568
##########
build.xml:
##########
@@ -1027,6 +1028,22 @@
</copy>
</target>
+ <macrodef name="checktestnameshelper">
+ <sequential>
+ <taskdef name="test-name-check_" classname="org.apache.cassandra.anttasks.TestNameCheckTask" classpath="${test.classes}">
+ <classpath>
+ <path refid="cassandra.classpath.test"/>
+ <path location="${fqltool.build.classes}"/>
+ </classpath>
+ </taskdef>
+ <test-name-check_/>
+ </sequential>
+ </macrodef>
+
+ <target name="check-test-names" depends="_main-jar,stress-build,fqltool-build,resolver-dist-lib,simulator-jars,_build-test">
+ <checktestnameshelper/>
+ </target>
Review Comment:
I think so. Why not? There is target for checkstyle as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085341743
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -0,0 +1,85 @@
+/*
Review Comment:
given this is for tests I believe it is most suitable to put it among test sources, yes. There are already classes in this directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085420149
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -0,0 +1,85 @@
+/*
Review Comment:
Honestly I am not sure how this will look like but it is noted and we may create new ticket to move all ant tasks out of `test`. As of now, based on this communication, I consider this to be resolved in regards to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085326063
##########
ide/idea-iml-file.xml:
##########
@@ -30,6 +30,7 @@
<sourceFolder url="file://$MODULE_DIR$/tools/stress/test/unit" isTestSource="true" />
<sourceFolder url="file://$MODULE_DIR$/tools/fqltool/src" isTestSource="false" />
<sourceFolder url="file://$MODULE_DIR$/tools/fqltool/test/unit" isTestSource="true" />
+ <sourceFolder url="file://$MODULE_DIR$/test/anttasks" isTestSource="true" />
Review Comment:
nit: there's a similar line to add in the netbeans file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085337745
##########
test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:
##########
@@ -0,0 +1,85 @@
+/*
Review Comment:
opinion: is `test/anttasks/` really the most intuitive place? I would have thought either `src/anttasks/` or `.build/anttasks/` would make more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic closed pull request #1990: CASSANDRA-17964 ant trunk
URL: https://github.com/apache/cassandra/pull/1990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085334341
##########
build.xml:
##########
@@ -1027,6 +1028,22 @@
</copy>
</target>
+ <macrodef name="checktestnameshelper">
+ <sequential>
+ <taskdef name="test-name-check_" classname="org.apache.cassandra.anttasks.TestNameCheckTask" classpath="${test.classes}">
+ <classpath>
+ <path refid="cassandra.classpath.test"/>
+ <path location="${fqltool.build.classes}"/>
+ </classpath>
+ </taskdef>
+ <test-name-check_/>
+ </sequential>
+ </macrodef>
+
+ <target name="check-test-names" depends="_main-jar,stress-build,fqltool-build,resolver-dist-lib,simulator-jars,_build-test">
+ <checktestnameshelper/>
+ </target>
Review Comment:
nit: is there _actually_ need for a separate target?
##########
build.xml:
##########
@@ -1027,6 +1028,22 @@
</copy>
</target>
+ <macrodef name="checktestnameshelper">
+ <sequential>
+ <taskdef name="test-name-check_" classname="org.apache.cassandra.anttasks.TestNameCheckTask" classpath="${test.classes}">
+ <classpath>
+ <path refid="cassandra.classpath.test"/>
+ <path location="${fqltool.build.classes}"/>
+ </classpath>
+ </taskdef>
+ <test-name-check_/>
+ </sequential>
+ </macrodef>
Review Comment:
nit: what about adding these changes into `.build/build-linter.xml` file (along with all the existing checkstyle and linter stuff)? including standardising the way we skip the linter tasks.
this was discussed a little in CASSANDRA-18077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085343936
##########
build.xml:
##########
@@ -1027,6 +1028,22 @@
</copy>
</target>
+ <macrodef name="checktestnameshelper">
+ <sequential>
+ <taskdef name="test-name-check_" classname="org.apache.cassandra.anttasks.TestNameCheckTask" classpath="${test.classes}">
+ <classpath>
+ <path refid="cassandra.classpath.test"/>
+ <path location="${fqltool.build.classes}"/>
+ </classpath>
+ </taskdef>
+ <test-name-check_/>
+ </sequential>
+ </macrodef>
Review Comment:
Interesting, I will check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1990: CASSANDRA-17964 ant trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #1990:
URL: https://github.com/apache/cassandra/pull/1990#discussion_r1085358803
##########
build.xml:
##########
@@ -1027,6 +1028,22 @@
</copy>
</target>
+ <macrodef name="checktestnameshelper">
+ <sequential>
+ <taskdef name="test-name-check_" classname="org.apache.cassandra.anttasks.TestNameCheckTask" classpath="${test.classes}">
+ <classpath>
+ <path refid="cassandra.classpath.test"/>
+ <path location="${fqltool.build.classes}"/>
+ </classpath>
+ </taskdef>
+ <test-name-check_/>
+ </sequential>
+ </macrodef>
+
+ <target name="check-test-names" depends="_main-jar,stress-build,fqltool-build,resolver-dist-lib,simulator-jars,_build-test">
+ <checktestnameshelper/>
+ </target>
Review Comment:
We may remove that. I dont object. As long as it is called as part of the build, the separate target is not the absolute must.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org