You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/13 00:32:54 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #12330: Improve presentation of DAG Docs
ryanahamilton opened a new pull request #12330:
URL: https://github.com/apache/airflow/pull/12330
Noticed that the DAG docs/comments weren't looking so sharp… Refactored their markup/presentation a bit to now be contained within an accordion. It is still only conditionally displayed on the Tree and Graph views.
**Before:**
**After:**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #12330: Improve presentation of DAG Docs
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #12330:
URL: https://github.com/apache/airflow/pull/12330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12330: Improve presentation of DAG Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12330:
URL: https://github.com/apache/airflow/pull/12330#issuecomment-726441080
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12330: Improve presentation of DAG Docs
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12330:
URL: https://github.com/apache/airflow/pull/12330#issuecomment-726731048
tests are failing:
```
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_code - jinja2.exce...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_code_from_db - jin...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_code_from_db_all_example_dags
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_code_no_file - jin...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_dag_details - jinj...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_dag_details_subdag
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_dag_details_trigger_origin_graph_view
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_dag_details_trigger_origin_tree_view
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_duration - jinja2....
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_gantt - jinja2.exc...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_landing_times - ji...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_rendered_k8s - jin...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_rendered_template
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_task - jinja2.exce...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_tries - jinja2.exc...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_view_uses_existing_dagbag_2_dag_details
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_xcom - jinja2.exce...
FAILED tests/www/test_views.py::TestGanttView::test_dt_nr_dr_form_default_parameters
FAILED tests/www/test_views.py::TestGanttView::test_dt_nr_dr_form_with_base_date_and_num_runs_and_execution_date_outside
FAILED tests/www/test_views.py::TestGanttView::test_dt_nr_dr_form_with_base_date_and_num_runs_and_execution_date_within
FAILED tests/www/test_views.py::TestGanttView::test_dt_nr_dr_form_with_base_date_and_num_runs_parameters_only
FAILED tests/www/test_views.py::TestGanttView::test_dt_nr_dr_form_with_execution_date_parameter_only
FAILED tests/www/test_views.py::TestDagACLView::test_code_success - jinja2.ex...
FAILED tests/www/test_views.py::TestDagACLView::test_code_success_for_all_dag_user
FAILED tests/www/test_views.py::TestDagACLView::test_dag_details_success - ji...
FAILED tests/www/test_views.py::TestDagACLView::test_dag_details_success_for_all_dag_user
FAILED tests/www/test_views.py::TestDagACLView::test_duration_success - jinja...
FAILED tests/www/test_views.py::TestDagACLView::test_gantt_success - jinja2.e...
FAILED tests/www/test_views.py::TestDagACLView::test_landing_times_success - ...
FAILED tests/www/test_views.py::TestDagACLView::test_log_success - jinja2.exc...
FAILED tests/www/test_views.py::TestDagACLView::test_log_success_for_user - j...
FAILED tests/www/test_views.py::TestDagACLView::test_rendered_template_success
FAILED tests/www/test_views.py::TestDagACLView::test_rendered_template_success_for_all_dag_user
FAILED tests/www/test_views.py::TestDagACLView::test_task_success - jinja2.ex...
FAILED tests/www/test_views.py::TestDagACLView::test_task_success_for_all_dag_user
FAILED tests/www/test_views.py::TestDagACLView::test_tries_success - jinja2.e...
FAILED tests/www/test_views.py::TestDagACLView::test_xcom_success - jinja2.ex...
FAILED tests/www/test_views.py::TestDagACLView::test_xcom_success_for_all_dag_user
FAILED tests/www/test_views.py::TestRenderedView::test_rendered_template_view
FAILED tests/www/test_views.py::TestRenderedView::test_rendered_template_view_for_unexecuted_tis
FAILED tests/www/test_views.py::TestRenderedView::test_user_defined_filter_and_macros_raise_error
FAILED tests/www/test_views.py::TestExtraLinks::test_extra_link_in_gantt_view
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org