You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/01/06 17:50:08 UTC

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4258: api_capabilities request query parameter and response key mismatch

ZugNZwang opened a new issue #4258: api_capabilities request query parameter and response key mismatch
URL: https://github.com/apache/trafficcontrol/issues/4258
 
 
   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   -->
   
   <!--
   - For *SUPPORT QUESTIONS*, use the
   [Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
   
   ## I'm submitting a ...
   <!-- (check all that apply with "[x]") -->
   <!--- security vulnerability (STOP!! - see above)-->
   - [ ] bug report
   - [ ] new feature / enhancement request
   - [X] improvement request (usability, performance, tech debt, etc.)
   - [ ] other <!--(Please do not submit support requests here - see above)-->
   
   ## Traffic Control components affected ...
   <!-- (check all that apply with "[x]") -->
   - [ ] CDN in a Box
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Control Client
   - [ ] Traffic Monitor
   - [X] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] unknown
   
   ## Current behavior:
   <!-- Describe how the bug manifests / how the current features are insufficient. -->
   When making a `GET` request to `api_capabilities` with the following query parameter:
   `?route=user/login` the response return is:
   ```
   HTTP\1.1 200 OK
   {
       "response": [
           {
               "id": 1,
               "httpMethod": "POST",
               "httpRoute": "user/login",
               "capability": "auth",
               "lastUpdated": "2020-01-06 12:14:40+00"
           }
       ]
   }
   ```
   However, there is no `route` key in the response. Only a `httpRoute` key.
   
   ## Expected / new behavior:
   <!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
   The requested query parameter should match the response key:
   `?httpRoute=user/login`
   ## Minimal reproduction of the problem with instructions:
   <!--
   If the current behavior is a bug or you can illustrate your feature request better with an example,
   please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
   -->
   
   ## Anything else:
   <!-- e.g. stacktraces, related issues, suggestions how to fix -->
   This query parameter did not exist in the perl. This query parameter should either be removed or be improved to match the response key.
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4258: api_capabilities request query parameter and response key mismatch

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4258: api_capabilities request query parameter and response key mismatch
URL: https://github.com/apache/trafficcontrol/issues/4258#issuecomment-571313544
 
 
   this bug is related to #4253 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4258: api_capabilities request query parameter and response key mismatch

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4258: api_capabilities request query parameter and response key mismatch
URL: https://github.com/apache/trafficcontrol/issues/4258#issuecomment-571308321
 
 
   This is a result of the earlier bug where the field was named `route` instead of `httpRoute`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4258: api_capabilities request query parameter and response key mismatch

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4258: api_capabilities request query parameter and response key mismatch
URL: https://github.com/apache/trafficcontrol/issues/4258#issuecomment-571239389
 
 
   Is the `route` parameter new? Or did Perl support it as well? I don't think it did, but I could be wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4258: api_capabilities request query parameter and response key mismatch

Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4258: api_capabilities request query parameter and response key mismatch
URL: https://github.com/apache/trafficcontrol/issues/4258#issuecomment-571313544
 
 
   this bug is related to #4244  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4258: api_capabilities request query parameter and response key mismatch

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4258: api_capabilities request query parameter and response key mismatch
URL: https://github.com/apache/trafficcontrol/issues/4258#issuecomment-571306714
 
 
   ?route=user/login should have no effect imo as there is no `route` but only an `httpRoute` as far as the api is concerned.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ZugNZwang commented on issue #4258: api_capabilities request query parameter and response key mismatch

Posted by GitBox <gi...@apache.org>.
ZugNZwang commented on issue #4258: api_capabilities request query parameter and response key mismatch
URL: https://github.com/apache/trafficcontrol/issues/4258#issuecomment-571243460
 
 
   It is new. Perl did not support it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services