You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Udo Kohlmeyer <uk...@gmail.com> on 2016/02/17 11:15:16 UTC
Review Request 43647: GEODE-636: Removing DNS resolution for test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43647/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen.
Repository: geode
Description
-------
GEODE-636: Removing DNS resolution for test.
Diffs
-----
gemfire-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java c25a1db7dfdd799b88591b8b1315638eed4a6a07
Diff: https://reviews.apache.org/r/43647/diff/
Testing
-------
UniversalMembershipListenerAdapterDUnitTest
Thanks,
Udo Kohlmeyer
Re: Review Request 43647: GEODE-636: Removing DNS resolution for test
Posted by Udo Kohlmeyer <uk...@gmail.com>.
> On Feb. 17, 2016, 4:36 p.m., Bruce Schuchardt wrote:
> > I don't think this is the correct fix for GEODE-636. The failure was
> >
> > expected:<...o6(16540:loner)<ec>:[0]:67c8047a> but was:<...o6(16540:loner)<ec>:[48516]:67c8047a>
> >
> > showing that the port number in the cached clientMemberId was zero but it was 48516 in the membership event. I think this bug has already been fixed in c4591fa, when I fixed GEODE-841. That commit removed the "<ec>" from the toString of client identifiers, which allows ClientServerTestBase.getMemberId() to properly wait for the client to connect to the server and establish its unique port number in the ID.
Ah.. correct. The port is populating correctly for testLonerClientEventsInServer.
I mistook this failure for a similar failure I keep getting when running the UniversalMembershipListenerAdapterDUnitTest.testServerEventsInLonerClient.
junit.framework.ComparisonFailure:
Expected :192.168.1.73(73715)<ec><v1>:1025
Actual :Udos-MacBook-Pro(73715)<ec><v1>:1025
Reverting now.
- Udo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43647/#review119474
-----------------------------------------------------------
On Feb. 17, 2016, 10:15 a.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43647/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 10:15 a.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-636: Removing DNS resolution for test.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java c25a1db7dfdd799b88591b8b1315638eed4a6a07
>
> Diff: https://reviews.apache.org/r/43647/diff/
>
>
> Testing
> -------
>
> UniversalMembershipListenerAdapterDUnitTest
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 43647: GEODE-636: Removing DNS resolution for test
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43647/#review119474
-----------------------------------------------------------
I don't think this is the correct fix for GEODE-636. The failure was
expected:<...o6(16540:loner)<ec>:[0]:67c8047a> but was:<...o6(16540:loner)<ec>:[48516]:67c8047a>
showing that the port number in the cached clientMemberId was zero but it was 48516 in the membership event. I think this bug has already been fixed in c4591fa, when I fixed GEODE-841. That commit removed the "<ec>" from the toString of client identifiers, which allows ClientServerTestBase.getMemberId() to properly wait for the client to connect to the server and establish its unique port number in the ID.
- Bruce Schuchardt
On Feb. 17, 2016, 10:15 a.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43647/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 10:15 a.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-636: Removing DNS resolution for test.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java c25a1db7dfdd799b88591b8b1315638eed4a6a07
>
> Diff: https://reviews.apache.org/r/43647/diff/
>
>
> Testing
> -------
>
> UniversalMembershipListenerAdapterDUnitTest
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>