You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/01/30 15:58:06 UTC
[GitHub] timbru31 commented on a change in pull request #124: chore: drop
Node.js v4 support
timbru31 commented on a change in pull request #124: chore: drop Node.js v4 support
URL: https://github.com/apache/cordova-plugin-statusbar/pull/124#discussion_r252319190
##########
File path: .appveyor.yml
##########
@@ -12,12 +12,12 @@ image:
- Visual Studio 2017
environment:
- nodejs_version: "4"
+ nodejs_version: "6"
matrix:
- PLATFORM: windows-10-store
JUST_BUILD: --justBuild
install:
- - npm cache clean -f
+ - ps: Install-Product node $env:nodejs_version
Review comment:
You need this line to actually switch/install the Node.js version. Otherwise it's defined in the matrix, but not switched.
See e.g. this build https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-plugin-statusbar/builds/21982309 (commit: https://github.com/apache/cordova-plugin-statusbar/commit/4946a7dc18f22b5b713c4fc484300b711f3dad6b#diff-11c909939117928998b102a1fff7d363L19) vs this: https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-plugin-statusbar/builds/21982952 (commit: https://github.com/apache/cordova-plugin-statusbar/commit/55063d025b40665832ac65de12f608b1b41fea54#diff-11c909939117928998b102a1fff7d363R20)
(documentation: https://www.appveyor.com/docs/lang/nodejs-iojs/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org