You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/01/31 13:36:45 UTC

[GitHub] brooklyn-server pull request #545: Delete EntityFactory

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/545

    Delete EntityFactory

    One should instead always use `EntitySpec`, e.g. with `DynamicCluster` memberSpec config.
    
    This PR also:
    * refactors tests so that they use memberSpec instead of entityFactory.
    * adds BlockingEntity.STARTUP_DELAY/SHUTDOWN_DELAY
    
    Note that some of the code I'm deleting we didn't properly deprecate, but I'm ok with that because it was sort-of deprecated, if indirectly! For example, `DynamicFabric.FACTORY` config key was not deprecated but the type of the config key (`EntityFactory`) has been deprecated since 0.7.0. Similarly, the classes `AbstractConfigurableEntityFactory` and `ClosureEntityFactory` were not deprecated but the interface `EntityFactory` was deprecated so it's clear enough that these classes should not have been used (even if direct use of them would not have given a nice deprecation warning).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server delete-deprecated-EntityFactory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/545.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #545
    
----
commit 0bf373a4ab6af4a5120c1b759a38598fe7761e39
Author: Aled Sage <al...@gmail.com>
Date:   2017-01-30T19:12:40Z

    Delete EntityFactory
    
    Also:
    * refactors tests so that they use memberSpec instead of 
    entityFactory.
    * adds BlockingEntity.STARTUP_DELAY/SHUTDOWN_DELAY

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #545: Delete EntityFactory

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-server/pull/545
  
    LGTM. Tests passing locally, also tried a successful deployment. Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #545: Delete EntityFactory

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/545


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---