[jira] [Commented] (CALCITE-5745) CONCAT2 function (enabled in Oracle library) gets wrong result when one of the arguments is NULL

["ZheHu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730420#comment-17730420 ] 

ZheHu commented on CALCITE-5745:
--------------------------------

Per the above discussion, I filed CALCITE-5771 to implement two NULL semantics for CONCAT.
But for MSSQL, we may still need to add a function(maybe MSSQL_CONCAT) based on its accepted args. Should I need another JIRA case(since we don't enable CONCAT in MSSQL currently) or I can implement it in CALCITE-5771? What do you think [~julianhyde]?

> CONCAT2 function (enabled in Oracle library) gets wrong result when one of the arguments is NULL
> ------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-5745
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5745
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.34.0
>            Reporter: ZheHu
>            Assignee: ZheHu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.35.0
>
>
> Tested CONCAT function in Oracle and got the corresponding results.
> {code}
> select concat('a', cast(null as varchar(20))) from DUAL;
> --- results in 'a'
> {code}
> {code}
> select concat('a', null) from DUAL;
> select 'a' ||  null from DUAL;
> --- both result in 'a'
> {code}
> In Calcite(see checkConcat2Func() in SqlOperatorTest.java), CONCAT2 function gets null when running:
> {code}
> concat('a', cast(null as varchar))
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)