You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/08/19 06:08:52 UTC
[GitHub] [netbeans] junichi11 opened a new pull request #2319: [NETBEANS-4443] PHP 8.0 Support: Union Types 2.0
junichi11 opened a new pull request #2319:
URL: https://github.com/apache/netbeans/pull/2319
https://issues.apache.org/jira/browse/NETBEANS-4443
#### Part 1
- https://wiki.php.net/rfc/union_types_v2
- Fix `ASTPHP5Parser.cup`
- Fix `InitializeFieldSuggestion` hint
- Fix `PHP80UnhandledError` and `UnusableTypesUnhandledError`
- Add the flag for union types to index signatures
- Fix code generation features (generate getter, setter, constructor, override/implement methods)
- Add unit tests for the parser, code generator, indexer, and hints
#### Part 2
- Fix Code Completion feature
- Add `false`, `null`, `self`, and `parent` as code completion items for parameter/return type
- Fix the `GSFPHPParser` for sanitizing a union type part
#### Part 3
- Fix the `PhpCommentGenerator`
- Fix the formatter
- Add unit tests for the comment generator, goto declaration, mark occurrences, and formatting features
- Fix the `DocRenderer`: use actual parameter/return types if there is no PHPDoc
#### PHP 8.0 (Project Properties)
#### PHP 7.4 (Project Properties)
#### Demo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2319: [NETBEANS-4443] PHP 8.0 Support: Union Types 2.0
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2319:
URL: https://github.com/apache/netbeans/pull/2319#issuecomment-680218056
@junichi11 Nothing to thank for, really!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2319: [NETBEANS-4443] PHP 8.0 Support: Union Types 2.0
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2319:
URL: https://github.com/apache/netbeans/pull/2319#issuecomment-679996669
@tmysik There are many changes and they are complicated. So, of course, that's more than enough :) Thank you for your review and your time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2319: [NETBEANS-4443] PHP 8.0 Support: Union Types 2.0
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2319:
URL: https://github.com/apache/netbeans/pull/2319#issuecomment-679982313
@junichi11
Perfectly done, as always. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2319: [NETBEANS-4443] PHP 8.0 Support: Union Types 2.0
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2319:
URL: https://github.com/apache/netbeans/pull/2319#issuecomment-678438239
I will try to look at ASAP. Sorry!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik merged pull request #2319: [NETBEANS-4443] PHP 8.0 Support: Union Types 2.0
Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2319:
URL: https://github.com/apache/netbeans/pull/2319
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2319: [NETBEANS-4443] PHP 8.0 Support: Union Types 2.0
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2319:
URL: https://github.com/apache/netbeans/pull/2319#issuecomment-677982151
@tmysik I've created three commits, but the changes may be too many, sorry... Could you please review these when you can make time? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists