You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by stanlyxiang <gi...@git.apache.org> on 2017/05/03 07:32:20 UTC

[GitHub] incubator-hawq pull request #1229: HAWQ-1451. HAWQ state should be able to r...

GitHub user stanlyxiang opened a pull request:

    https://github.com/apache/incubator-hawq/pull/1229

    HAWQ-1451. HAWQ state should be able to report the status of both RPS…

    … and standby RPS

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stanlyxiang/incubator-hawq HAWQ-1451

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/1229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1229
    
----
commit f43b4fad3c6146ae43dd208a66564aaaaeedf0e8
Author: stanlyxiang <st...@gmail.com>
Date:   2017-05-03T07:28:43Z

    HAWQ-1451. HAWQ state should be able to report the status of both RPS and standby RPS

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1229: HAWQ-1451. HAWQ state should be able to r...

Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1229#discussion_r114691191
  
    --- Diff: tools/bin/hawqstate ---
    @@ -135,12 +138,14 @@ def show_brief_status(hawq_site, segment_list, standby_host):
         else:
             logger.info("-   No Standby master defined                           ")
         logger.info("-   Total segment instance count from config file  = %s"% total_seg_num)
    -    if 'hawq_acl_type' in hawq_site.hawq_dict:
    -        hawq_acl_type = hawq_site.hawq_dict['hawq_acl_type']
    -        logger.info("-   Current HAWQ acl type                          = %s" % hawq_acl_type)
    -        if hawq_acl_type == "ranger":
    -            hawq_rps_status = check_rps_status()
    -            logger.info("-   HAWQ Ranger plugin service state               = %s" % hawq_rps_status)
    +    logger.info("-----------------------------------------------------")
    +    logger.info("-   Current HAWQ acl type                          = %s" % hawq_acl_type)
    +    if hawq_acl_type == "ranger":
    +        hawq_master_rps_status = check_rps_status('hawq_master_address_host')
    +        logger.info("-   HAWQ master  Ranger plugin service state       = %s" % hawq_master_rps_status)
    --- End diff --
    
    a redundant space between "master" and "Ranger"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1229: HAWQ-1451. HAWQ state should be able to report t...

Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1229
  
    +1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1229: HAWQ-1451. HAWQ state should be able to r...

Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1229#discussion_r114692327
  
    --- Diff: tools/bin/hawqstate ---
    @@ -135,12 +138,14 @@ def show_brief_status(hawq_site, segment_list, standby_host):
         else:
             logger.info("-   No Standby master defined                           ")
         logger.info("-   Total segment instance count from config file  = %s"% total_seg_num)
    -    if 'hawq_acl_type' in hawq_site.hawq_dict:
    -        hawq_acl_type = hawq_site.hawq_dict['hawq_acl_type']
    -        logger.info("-   Current HAWQ acl type                          = %s" % hawq_acl_type)
    -        if hawq_acl_type == "ranger":
    -            hawq_rps_status = check_rps_status()
    -            logger.info("-   HAWQ Ranger plugin service state               = %s" % hawq_rps_status)
    +    logger.info("-----------------------------------------------------")
    +    logger.info("-   Current HAWQ acl type                          = %s" % hawq_acl_type)
    +    if hawq_acl_type == "ranger":
    +        hawq_master_rps_status = check_rps_status('hawq_master_address_host')
    +        logger.info("-   HAWQ master  Ranger plugin service state       = %s" % hawq_master_rps_status)
    --- End diff --
    
    fixed with new commit. Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1229: HAWQ-1451. HAWQ state should be able to r...

Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/1229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1229: HAWQ-1451. HAWQ state should be able to report t...

Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1229
  
    Merged into master. Close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---