[jira] [Commented] (HADOOP-18476) Abfs and S3A FileContext bindings to close wrapped filesystems in finalizer

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615272#comment-17615272 ] 

ASF GitHub Bot commented on HADOOP-18476:
-----------------------------------------

mukund-thakur commented on PR #4966:
URL: https://github.com/apache/hadoop/pull/4966#issuecomment-1273697911

   `he class holds strong references so finalize() won't be called, ever.`
   Are you referring to DELETE_ON_EXIT map?
   
   Changes looks good. there is just one checkstyle reported. 




> Abfs and S3A FileContext bindings to close wrapped filesystems in finalizer
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-18476
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18476
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure, fs/s3
>    Affects Versions: 3.3.4
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Blocker
>
> if you use the FileContext APIs to talk to abfs or s3a, it creates a new wrapped FileSystem implementation, and, because there is no close() call, never cleans up.
> proposed: add finalizers for these two classes, which we know create helper threads, especially if plugins are added



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org