[GitHub] [cordova-plugin-geolocation] timbru31 commented on a change in pull request #189: Variable for Require GPS Hardware

[GitBox <gi...@apache.org>]

timbru31 commented on a change in pull request #189: Variable for Require GPS Hardware
URL: https://github.com/apache/cordova-plugin-geolocation/pull/189#discussion_r394318397
 
 

 ##########
 File path: README.md
 ##########
 @@ -172,6 +172,11 @@ error, the `geolocationError` callback is passed a
  
 ### Android Quirks
 
+For historic reasons, this plugin requires GPS Hardware on Android devices, so your app will not be able to run on devices without.
+If you want to use this plugin in your app, but you do not require actual GPS Hardware on the device, install the plugin using the variable *GPS_REQUIRED*
 
 Review comment:
   I'd add a `[...] the variable *GPS_REQUIRED* set to false:`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org