[GitHub] [spark] ulysses-you commented on a change in pull request #28964: [SPARK-32144][SQL] Retain EXTERNAL property in hive table properties

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #28964:
URL: https://github.com/apache/spark/pull/28964#discussion_r448685743



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -478,13 +478,19 @@ private[hive] class HiveClientImpl(
       ignoredProperties += key -> value
     }
 
-    val excludedTableProperties = HiveStatisticsProperties ++ Set(
+    var excludedTableProperties = HiveStatisticsProperties ++ Set(
       // The property value of "comment" is moved to the dedicated field "comment"
-      "comment",
-      // For EXTERNAL_TABLE, the table properties has a particular field "EXTERNAL". This is added
-      // in the function toHiveTable.
-      "EXTERNAL"
+      "comment"
     )
+    // We should retain the external property if is useful
+    val externalExcluded = properties.get("EXTERNAL").map(_.toLowerCase(Locale.ROOT)) match {

Review comment:
       Hive always show the `EXTERNAL`, but it is not used in normal.
   
   We try best to avoid show the unnecessary property to follow spark since spark we can't modify `EXTERNAL`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org