You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2014/01/15 02:26:16 UTC
[Apache Bloodhound] #741: Update Whoosh dependency
#741: Update Whoosh dependency
---------------------------+-------------------------
Reporter: SaintGermain | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone: Unscheduled
Component: search | Version: 0.7.0
Keywords: whoosh search |
---------------------------+-------------------------
bloodhound_search currently requires the exact Whoosh 2.4.1 version.
Whoosh 2.4.1 contains a bug and a fix/workaround is included in
Bloodhound.
The Whoosh bug is corrected since version 2.5.1, branch 2.4.* is not
supported anymore and Whoosh is already at version 2.5.6.
The patch is easy as it requires only to properly remove the fix for 2.4.1
(see below).
See discussion on mailing-list:
http://markmail.org/message/ryglvplsq3hgvu3g
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/741>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #741: Update Whoosh dependency
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#741: Update Whoosh dependency
---------------------------+---------------------------
Reporter: SaintGermain | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone: Unscheduled
Component: search | Version: 0.7.0
Resolution: | Keywords: whoosh search
---------------------------+---------------------------
Comment (by astaric):
I have applied the patch locally and run the test suite. There were two
failures (one related to product field sometimes being empty and one bug
in !SecurityFilter). They were fixed in r1559082 and r1559080 accordingly.
Please report if you notice any other problems with your manual testing.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/741#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #741: Update Whoosh dependency
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#741: Update Whoosh dependency
---------------------------+---------------------------
Reporter: SaintGermain | Owner: nobody
Type: enhancement | Status: closed
Priority: major | Milestone: Unscheduled
Component: search | Version: 0.7.0
Resolution: fixed | Keywords: whoosh search
---------------------------+---------------------------
Changes (by SaintGermain):
* status: new => closed
* resolution: => fixed
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/741#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #741: Update Whoosh dependency
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#741: Update Whoosh dependency
---------------------------+---------------------------
Reporter: SaintGermain | Owner: nobody
Type: enhancement | Status: closed
Priority: major | Milestone: Unscheduled
Component: search | Version: 0.7.0
Resolution: fixed | Keywords: whoosh search
---------------------------+---------------------------
Comment (by SaintGermain):
Fixed in commit r1566160
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/741#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #741: Update Whoosh dependency
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#741: Update Whoosh dependency
---------------------------+---------------------------
Reporter: SaintGermain | Owner: nobody
Type: enhancement | Status: closed
Priority: major | Milestone: Release 8
Component: search | Version: 0.7.0
Resolution: fixed | Keywords: whoosh search
---------------------------+---------------------------
Comment (by rjollos):
(In [1583082])
0.8dev: Removed imports that are not needed after r1566160. Refs #741.
Some additional PEP-0008 changes.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/741#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #741: Update Whoosh dependency
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#741: Update Whoosh dependency
---------------------------+---------------------------
Reporter: SaintGermain | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone: Unscheduled
Component: search | Version: 0.7.0
Resolution: | Keywords: whoosh search
---------------------------+---------------------------
Comment (by SaintGermain):
Ok I have tried the following manually:
1. Free text search
* summary
* body
* comment
1. Field specific
* status:new
* status:closed
1. Operators test
* OR
* AND
* NOT
1. Meta-keywords
* $resolved
* $unresolved
* $me
1. Search tickets based on relations
* duplicatedby:*
I was not sure about the range function (is it for the search box ?). But
it triggered an exception when I tried (for instance date:[20050101 TO
20090715] or title:{Aida TO Carmen}):
{{{#!python
Internal Server Error: /fr/bloodhound/bhsearch
Traceback (most recent call last):
File "/home/user/project/bloodhound/trac/trac/web/main.py", line 445, in
dispatch_request
return _dispatch_request(req, env, env_error)
File "/home/user/project/bloodhound/trac/trac/web/main.py", line 484, in
_dispatch_request
send_internal_error(env, req, sys.exc_info())
File "/home/user/project/bloodhound/trac/trac/web/main.py", line 615, in
send_internal_error
req.send_error(exc_info, status=500, env=env, data=data)
File "/home/user/project/bloodhound/trac/trac/web/api.py", line 536, in
send_error
exc_info)
File "/home/user/project/bloodhound/trac/trac/web/main.py", line 477, in
_dispatch_request
dispatcher.dispatch(req)
File "/home/user/project/bloodhound/trac/trac/web/main.py", line 214, in
dispatch
resp = chosen_handler.process_request(req)
File
"/home/user/project/bloodhound/bloodhound_search/bhsearch/web_ui.py", line
346, in process_request
context=request_context,
File "/home/user/project/bloodhound/bloodhound_search/bhsearch/api.py",
line 316, in query
query_result = self.backend.query(**query_parameters)
File
"/home/user/project/bloodhound/bloodhound_search/bhsearch/whoosh_backend.py",
line 247, in query
c = searcher.correct_query(query, query_string)
File "/home/user/.virtualenvs/test/local/lib/python2.7/site-
packages/whoosh/searching.py", line 918, in correct_query
for token in q.all_tokens():
File "/home/user/.virtualenvs/test/local/lib/python2.7/site-
packages/whoosh/query/qcore.py", line 424, in all_tokens
for token in child.all_tokens(boost):
File "/home/user/.virtualenvs/test/local/lib/python2.7/site-
packages/whoosh/query/qcore.py", line 424, in all_tokens
for token in child.all_tokens(boost):
File "/home/user/.virtualenvs/test/local/lib/python2.7/site-
packages/whoosh/query/qcore.py", line 419, in all_tokens
for token in self.tokens(boost):
File "/home/user/.virtualenvs/test/local/lib/python2.7/site-
packages/whoosh/query/terms.py", line 165, in tokens
btexts = [self.text]
AttributeError: 'TermRange' object has no attribute 'text'
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/741#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #741: Update Whoosh dependency
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#741: Update Whoosh dependency
---------------------------+---------------------------
Reporter: SaintGermain | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone: Unscheduled
Component: search | Version: 0.7.0
Resolution: | Keywords: whoosh search
---------------------------+---------------------------
Comment (by astaric):
I have tried out the latest patch and it works ok.
The error you get when using range queries looks like a problem in Whoosh
(searcher.correct_query is a call to Whoosh's "did you mean"
functionality). I have not yet had the time to debug it fully.
The fact that search crashes if something goes wrong in the whoosh backend
is a problem, but I suppose it belongs in another ticket.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/741#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #741: Update Whoosh dependency
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#741: Update Whoosh dependency
---------------------------+---------------------------
Reporter: SaintGermain | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone: Unscheduled
Component: search | Version: 0.7.0
Resolution: | Keywords: whoosh search
---------------------------+---------------------------
Comment (by SaintGermain):
I have added a tentative patch which removes the Whoosh fix/workaround and
remove/modify the tests accordingly (but I haven't added any more tests).
I have never really use the Bloodhound search features so I am not sure at
all about the patch (not tested).
I will try to test the search features manually in the next days and
update the patch if necessary.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/741#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #741: Update Whoosh dependency
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#741: Update Whoosh dependency
---------------------------+---------------------------
Reporter: SaintGermain | Owner: nobody
Type: enhancement | Status: closed
Priority: major | Milestone: Release 8
Component: search | Version: 0.7.0
Resolution: fixed | Keywords: whoosh search
---------------------------+---------------------------
Changes (by rjollos):
* milestone: Unscheduled => Release 8
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/741#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #741: Update Whoosh dependency
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#741: Update Whoosh dependency
---------------------------+---------------------------
Reporter: SaintGermain | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone: Unscheduled
Component: search | Version: 0.7.0
Resolution: | Keywords: whoosh search
---------------------------+---------------------------
Comment (by SaintGermain):
I would need some guidance to see if we need additional tests.
Can someone confirm that:
* tests of the Whoosh API is done in
bloodhound_search/bhsearch/tests/whoosh_backend.py
* tests of the search through the web interface is done in
bloodhound_search/bhsearch/tests/web_ui.py
* is the tests through the web interface means that we are testing through
the URL or through the Search box ?
In addition it seems that the call to the search backend is not
"protected" from exception.
If the backend failed with an exception, what should be the behavior ?
Do we return an empty result or an error message ?
Thanks !
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/741#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker