You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/11/18 06:30:07 UTC
[GitHub] [helix] kaisun2000 opened a new pull request #1542: Fix dependency for some tests
kaisun2000 opened a new pull request #1542:
URL: https://github.com/apache/helix/pull/1542
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
(#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
Fix dependency for some tests. Some of the test running
under surefire + testng would interleave the test cases in
the same test class to other test classes. Examine the log
would be very confusing.
Also enhance the base test case logging a little bit to
output both test class and test case names.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [ ] The following is the result of the "mvn test" command on the appropriate module:
(Before CI test pass, please copy & paste the result of "mvn test")
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1542: Fix dependency for some tests
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1542:
URL: https://github.com/apache/helix/pull/1542#discussion_r526332675
##########
File path: helix-core/src/test/java/org/apache/helix/integration/TestPartitionMovementThrottle.java
##########
@@ -278,7 +278,7 @@ public void testThrottleOnlyClusterLevelAnyType() {
ClusterLiveNodesVerifier liveNodesVerifier =
new ClusterLiveNodesVerifier(_gZkClient, CLUSTER_NAME,
Lists.transform(Arrays.asList(_participants), MockParticipantManager::getInstanceName));
- Assert.assertTrue(liveNodesVerifier.verifyByZkCallback(1000));
+ Assert.assertTrue(liveNodesVerifier.verifyByZkCallback(5000));
Review comment:
TestHelper.WAIT_DURATION?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1542: Fix dependency for some tests
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1542:
URL: https://github.com/apache/helix/pull/1542#issuecomment-748393028
@kaisun2000 Since we have already claimed that the test is now stabilized enough, is this PR still needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on a change in pull request #1542: Fix dependency for some tests
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on a change in pull request #1542:
URL: https://github.com/apache/helix/pull/1542#discussion_r526433295
##########
File path: helix-core/src/test/java/org/apache/helix/integration/TestPartitionMovementThrottle.java
##########
@@ -278,7 +278,7 @@ public void testThrottleOnlyClusterLevelAnyType() {
ClusterLiveNodesVerifier liveNodesVerifier =
new ClusterLiveNodesVerifier(_gZkClient, CLUSTER_NAME,
Lists.transform(Arrays.asList(_participants), MockParticipantManager::getInstanceName));
- Assert.assertTrue(liveNodesVerifier.verifyByZkCallback(1000));
+ Assert.assertTrue(liveNodesVerifier.verifyByZkCallback(5000));
Review comment:
good point. fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 edited a comment on pull request #1542: Fix dependency for some tests
Posted by GitBox <gi...@apache.org>.
kaisun2000 edited a comment on pull request #1542:
URL: https://github.com/apache/helix/pull/1542#issuecomment-730074364
> Seems the test cannot finish in the github run result. Could you please update the test result in your local environment?
The following is the failure log. The TestClusterStateVerifier failure is introduced https://github.com/apache/helix/pull/1534/. Note `_clusterName = className + "_" + methodName;` is missed. The fix is in https://github.com/apache/helix/pull/1541/.
So this PR is looking good.
Note, without #1541 in, current master would have consistent failure like this.
>2020-11-18T23:00:01.1037581Z [ERROR] Tests run: 1251, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 5,185.592 s <<< FAILURE! - in TestSuite
2020-11-18T23:00:01.1039247Z [ERROR] beforeMethod(org.apache.helix.tools.TestClusterStateVerifier) Time elapsed: 5.452 s <<< FAILURE!
2020-11-18T23:00:01.1040860Z org.apache.helix.HelixException: cluster null is not setup yet
2020-11-18T23:00:01.1043135Z at org.apache.helix.tools.TestClusterStateVerifier.beforeMethod(TestClusterStateVerifier.java:57)
2020-11-18T23:00:01.1044683Z
2020-11-18T23:00:01.5017540Z [ERROR] Failures:
2020-11-18T23:00:01.5020256Z [ERROR] org.apache.helix.tools.TestClusterStateVerifier.beforeMethod(org.apache.helix.tools.TestClusterStateVerifier)
2020-11-18T23:00:01.5031613Z [ERROR] Run 1: TestClusterStateVerifier.beforeMethod:57 » Helix cluster null is not setup yet
2020-11-18T23:00:01.5032997Z [ERROR] Tests run: 1249, Failures: 1, Errors: 0, Skipped: 3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on pull request #1542: Fix dependency for some tests
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on pull request #1542:
URL: https://github.com/apache/helix/pull/1542#issuecomment-730074364
> Seems the test cannot finish in the github run result. Could you please update the test result in your local environment?
The following is the failure. The TestClusterStateVerifier is introduced https://github.com/apache/helix/pull/1534/. Note `_clusterName = className + "_" + methodName;` is missed. The fix is in https://github.com/apache/helix/pull/1541/.
So this PR is looking good.
Note, without #1541 in, current master would have consistent failure like this.
>2020-11-18T23:00:01.1037581Z [ERROR] Tests run: 1251, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 5,185.592 s <<< FAILURE! - in TestSuite
2020-11-18T23:00:01.1039247Z [ERROR] beforeMethod(org.apache.helix.tools.TestClusterStateVerifier) Time elapsed: 5.452 s <<< FAILURE!
2020-11-18T23:00:01.1040860Z org.apache.helix.HelixException: cluster null is not setup yet
2020-11-18T23:00:01.1043135Z at org.apache.helix.tools.TestClusterStateVerifier.beforeMethod(TestClusterStateVerifier.java:57)
2020-11-18T23:00:01.1044683Z
2020-11-18T23:00:01.5017540Z [ERROR] Failures:
2020-11-18T23:00:01.5020256Z [ERROR] org.apache.helix.tools.TestClusterStateVerifier.beforeMethod(org.apache.helix.tools.TestClusterStateVerifier)
2020-11-18T23:00:01.5031613Z [ERROR] Run 1: TestClusterStateVerifier.beforeMethod:57 » Helix cluster null is not setup yet
2020-11-18T23:00:01.5032997Z [ERROR] Tests run: 1249, Failures: 1, Errors: 0, Skipped: 3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang closed pull request #1542: Fix dependency for some tests
Posted by GitBox <gi...@apache.org>.
jiajunwang closed pull request #1542:
URL: https://github.com/apache/helix/pull/1542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1542: Fix dependency for some tests
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1542:
URL: https://github.com/apache/helix/pull/1542#issuecomment-834664659
Close due to inactive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org