You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/05 06:08:05 UTC
[GitHub] [incubator-uniffle] zuston opened a new pull request, #128: Avoid starting unused threads in spark driver
zuston opened a new pull request, #128:
URL: https://github.com/apache/incubator-uniffle/pull/128
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Avoid starting unused threads in spark driver
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
In Spark RssShuffleManager, for the role of driver, there is no need to start send blocks threads.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
No need
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #128:
URL: https://github.com/apache/incubator-uniffle/pull/128#issuecomment-1206356332
Actually I think it brings extra complexity in order to avoid initializing a thread, it's a little worthless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #128:
URL: https://github.com/apache/incubator-uniffle/pull/128#discussion_r938657800
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -177,19 +177,27 @@ public RssShuffleManager(SparkConf sparkConf, boolean isDriver) {
sparkConf.set("spark.shuffle.service.enabled", "false");
LOG.info("Disable external shuffle service in RssShuffleManager.");
if (!sparkConf.getBoolean(RssSparkConfig.RSS_TEST_FLAG.key(), false)) {
- // for non-driver executor, start a thread for sending shuffle data to shuffle server
- LOG.info("RSS data send thread is starting");
- eventLoop.start();
- int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
- int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
- threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
- Queues.newLinkedBlockingQueue(Integer.MAX_VALUE),
- ThreadUtils.getThreadFactory("SendData-%d"));
-
if (isDriver) {
heartBeatScheduledExecutorService = Executors.newSingleThreadScheduledExecutor(
ThreadUtils.getThreadFactory("rss-heartbeat-%d"));
}
+
+ if (!isDriver || String.valueOf(true).equals(System.getProperty("TEST"))) {
Review Comment:
Could we use a config option? We have a config option named `RSS_TEST_FLAG`, Should we keep consistent with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #128:
URL: https://github.com/apache/incubator-uniffle/pull/128#issuecomment-1221730858
I'll close it, if you have another better solution, you can raise another pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #128:
URL: https://github.com/apache/incubator-uniffle/pull/128#discussion_r938653735
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -179,18 +179,20 @@ public RssShuffleManager(SparkConf conf, boolean isDriver) {
LOG.info("Disable external shuffle service in RssShuffleManager.");
taskToSuccessBlockIds = Maps.newConcurrentMap();
taskToFailedBlockIds = Maps.newConcurrentMap();
- // for non-driver executor, start a thread for sending shuffle data to shuffle server
- LOG.info("RSS data send thread is starting");
- eventLoop = defaultEventLoop;
- eventLoop.start();
- int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
- int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
- threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
- Queues.newLinkedBlockingQueue(Integer.MAX_VALUE),
- ThreadUtils.getThreadFactory("SendData-%d"));
+
if (isDriver) {
heartBeatScheduledExecutorService = Executors.newSingleThreadScheduledExecutor(
ThreadUtils.getThreadFactory("rss-heartbeat-%d"));
+ } else {
+ // for non-driver executor, start a thread for sending shuffle data to shuffle server
+ LOG.info("RSS data send thread is starting");
+ eventLoop = defaultEventLoop;
+ eventLoop.start();
+ int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
+ int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
+ threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
Review Comment:
> OK. I will add.
>
> > threadPoolExecutor may be null, when you stop, the Spark will throw NPE.
>
> Could u give more infos why it will be null?
You only assign a value to the threadPoolExecutor when the process is not driver. So the threadPoolExecutor will be null when the process is driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #128:
URL: https://github.com/apache/incubator-uniffle/pull/128#discussion_r938485692
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -179,18 +179,20 @@ public RssShuffleManager(SparkConf conf, boolean isDriver) {
LOG.info("Disable external shuffle service in RssShuffleManager.");
taskToSuccessBlockIds = Maps.newConcurrentMap();
taskToFailedBlockIds = Maps.newConcurrentMap();
- // for non-driver executor, start a thread for sending shuffle data to shuffle server
- LOG.info("RSS data send thread is starting");
- eventLoop = defaultEventLoop;
- eventLoop.start();
- int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
- int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
- threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
- Queues.newLinkedBlockingQueue(Integer.MAX_VALUE),
- ThreadUtils.getThreadFactory("SendData-%d"));
+
if (isDriver) {
heartBeatScheduledExecutorService = Executors.newSingleThreadScheduledExecutor(
ThreadUtils.getThreadFactory("rss-heartbeat-%d"));
+ } else {
+ // for non-driver executor, start a thread for sending shuffle data to shuffle server
+ LOG.info("RSS data send thread is starting");
+ eventLoop = defaultEventLoop;
+ eventLoop.start();
+ int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
+ int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
+ threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
Review Comment:
threadPoolExecutor may be null, when you stop, the Spark will throw NPE.
Could you add a integration WordCount test case for Spark with MiniYarnCluster. like https://github.com/apache/incubator-uniffle/blob/master/integration-test/mr/src/test/java/org/apache/uniffle/test/MRIntegrationTestBase.java. Because without such integration test, some problems won't be tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi closed pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
jerqi closed pull request #128: [Improvement] Avoid starting unused threads in spark driver
URL: https://github.com/apache/incubator-uniffle/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #128:
URL: https://github.com/apache/incubator-uniffle/pull/128#issuecomment-1206461528
> Actually I think it brings extra complexity in order to avoid initializing a thread, it's a little worthless.
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #128:
URL: https://github.com/apache/incubator-uniffle/pull/128#discussion_r938650067
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -179,18 +179,20 @@ public RssShuffleManager(SparkConf conf, boolean isDriver) {
LOG.info("Disable external shuffle service in RssShuffleManager.");
taskToSuccessBlockIds = Maps.newConcurrentMap();
taskToFailedBlockIds = Maps.newConcurrentMap();
- // for non-driver executor, start a thread for sending shuffle data to shuffle server
- LOG.info("RSS data send thread is starting");
- eventLoop = defaultEventLoop;
- eventLoop.start();
- int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
- int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
- threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
- Queues.newLinkedBlockingQueue(Integer.MAX_VALUE),
- ThreadUtils.getThreadFactory("SendData-%d"));
+
if (isDriver) {
heartBeatScheduledExecutorService = Executors.newSingleThreadScheduledExecutor(
ThreadUtils.getThreadFactory("rss-heartbeat-%d"));
+ } else {
+ // for non-driver executor, start a thread for sending shuffle data to shuffle server
+ LOG.info("RSS data send thread is starting");
+ eventLoop = defaultEventLoop;
+ eventLoop.start();
+ int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
+ int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
+ threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
Review Comment:
OK. I will add.
> threadPoolExecutor may be null, when you stop, the Spark will throw NPE.
Could u give more infos why it will be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #128:
URL: https://github.com/apache/incubator-uniffle/pull/128#discussion_r938659216
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -179,18 +179,20 @@ public RssShuffleManager(SparkConf conf, boolean isDriver) {
LOG.info("Disable external shuffle service in RssShuffleManager.");
taskToSuccessBlockIds = Maps.newConcurrentMap();
taskToFailedBlockIds = Maps.newConcurrentMap();
- // for non-driver executor, start a thread for sending shuffle data to shuffle server
- LOG.info("RSS data send thread is starting");
- eventLoop = defaultEventLoop;
- eventLoop.start();
- int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
- int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
- threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
- Queues.newLinkedBlockingQueue(Integer.MAX_VALUE),
- ThreadUtils.getThreadFactory("SendData-%d"));
+
if (isDriver) {
heartBeatScheduledExecutorService = Executors.newSingleThreadScheduledExecutor(
ThreadUtils.getThreadFactory("rss-heartbeat-%d"));
+ } else {
+ // for non-driver executor, start a thread for sending shuffle data to shuffle server
+ LOG.info("RSS data send thread is starting");
+ eventLoop = defaultEventLoop;
+ eventLoop.start();
+ int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
+ int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
+ threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
Review Comment:
But the threadPool is only invoked by the executor and closed when it's null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #128:
URL: https://github.com/apache/incubator-uniffle/pull/128#discussion_r938662891
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -177,19 +177,27 @@ public RssShuffleManager(SparkConf sparkConf, boolean isDriver) {
sparkConf.set("spark.shuffle.service.enabled", "false");
LOG.info("Disable external shuffle service in RssShuffleManager.");
if (!sparkConf.getBoolean(RssSparkConfig.RSS_TEST_FLAG.key(), false)) {
- // for non-driver executor, start a thread for sending shuffle data to shuffle server
- LOG.info("RSS data send thread is starting");
- eventLoop.start();
- int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
- int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
- threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
- Queues.newLinkedBlockingQueue(Integer.MAX_VALUE),
- ThreadUtils.getThreadFactory("SendData-%d"));
-
if (isDriver) {
heartBeatScheduledExecutorService = Executors.newSingleThreadScheduledExecutor(
ThreadUtils.getThreadFactory("rss-heartbeat-%d"));
}
+
+ if (!isDriver || String.valueOf(true).equals(System.getProperty("TEST"))) {
Review Comment:
Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #128: [Improvement] Avoid starting unused threads in spark driver
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #128:
URL: https://github.com/apache/incubator-uniffle/pull/128#discussion_r938700443
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -179,18 +179,20 @@ public RssShuffleManager(SparkConf conf, boolean isDriver) {
LOG.info("Disable external shuffle service in RssShuffleManager.");
taskToSuccessBlockIds = Maps.newConcurrentMap();
taskToFailedBlockIds = Maps.newConcurrentMap();
- // for non-driver executor, start a thread for sending shuffle data to shuffle server
- LOG.info("RSS data send thread is starting");
- eventLoop = defaultEventLoop;
- eventLoop.start();
- int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
- int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
- threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
- Queues.newLinkedBlockingQueue(Integer.MAX_VALUE),
- ThreadUtils.getThreadFactory("SendData-%d"));
+
if (isDriver) {
heartBeatScheduledExecutorService = Executors.newSingleThreadScheduledExecutor(
ThreadUtils.getThreadFactory("rss-heartbeat-%d"));
+ } else {
+ // for non-driver executor, start a thread for sending shuffle data to shuffle server
+ LOG.info("RSS data send thread is starting");
+ eventLoop = defaultEventLoop;
+ eventLoop.start();
+ int poolSize = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_SIZE);
+ int keepAliveTime = sparkConf.get(RssSparkConfig.RSS_CLIENT_SEND_THREAD_POOL_KEEPALIVE);
+ threadPoolExecutor = new ThreadPoolExecutor(poolSize, poolSize * 2, keepAliveTime, TimeUnit.SECONDS,
Review Comment:
Driver will call method `stop`,too. You can see https://github.com/Tencent/Firestorm/pull/187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org