[GitHub] [rocketmq] xiaoyifang commented on a diff in pull request #4390: [ISSUE #4389] Optimize for MixAll#properties2Object

["xiaoyifang (via GitHub)" <gi...@apache.org>]

xiaoyifang commented on code in PR #4390:
URL: https://github.com/apache/rocketmq/pull/4390#discussion_r1133598267


##########
common/src/test/java/org/apache/rocketmq/common/UtilAllTest.java:
##########
@@ -60,11 +60,17 @@ public void testProperties2String() {
         demoConfig.setDemoWidth(456);
         demoConfig.setDemoName("TestDemo");
         demoConfig.setDemoOK(true);
+        demoConfig.setDemoByte((byte) 78);
+        demoConfig.setDemoShort((short) 90);
+        demoConfig.setDemoChar('c');
         Properties properties = MixAll.object2Properties(demoConfig);
         assertThat(properties.getProperty("demoLength")).isEqualTo("123");
         assertThat(properties.getProperty("demoWidth")).isEqualTo("456");
         assertThat(properties.getProperty("demoOK")).isEqualTo("true");

Review Comment:
   you have modified properties2Object,  but test object2Properties method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org