You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/01/12 13:19:43 UTC
Review Request 55455: Moved `HealthChecker` into "checks" folder and
namespace.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55455/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
docs/health-checks.md 890e2983c2269d4b5fdbf70d9d19bec2b63cb2f1
src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c
src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7
src/health-check/CMakeLists.txt
src/health-check/health_checker.hpp 59831b12b99b87c15a51a7aa6c43b23be2c42a26
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
src/health-check/tcp_connect.cpp
src/launcher/default_executor.cpp 57e4799e750f8f5352a9fec58af40efe432ea865
src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f
src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
Diff: https://reviews.apache.org/r/55455/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 55455: Moved `HealthChecker` into "checks" folder
and namespace.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55455/#review162060
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 18, 2017, 10 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55455/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 10 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/health-checks.md 890e2983c2269d4b5fdbf70d9d19bec2b63cb2f1
> src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4
> src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db
> src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7
> src/health-check/CMakeLists.txt
> src/health-check/health_checker.hpp 59831b12b99b87c15a51a7aa6c43b23be2c42a26
> src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
> src/health-check/tcp_connect.cpp
> src/launcher/default_executor.cpp 57e4799e750f8f5352a9fec58af40efe432ea865
> src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
> src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0
> src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
>
> Diff: https://reviews.apache.org/r/55455/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55455: Moved `HealthChecker` into "checks" folder
and namespace.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55455/
-----------------------------------------------------------
(Updated Jan. 20, 2017, 2:49 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/health-checks.md 890e2983c2269d4b5fdbf70d9d19bec2b63cb2f1
src/CMakeLists.txt f242d47cb03eb67f299c84643edf23f3f6f313bb
src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db
src/docker/executor.cpp afb3ac20c3894b5bb441f71829684c3bf639c31f
src/health-check/CMakeLists.txt
src/health-check/health_checker.hpp 59831b12b99b87c15a51a7aa6c43b23be2c42a26
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
src/health-check/tcp_connect.cpp
src/launcher/default_executor.cpp f25905c06eadcca48ffa0a2fe6cb2c092b047282
src/launcher/executor.cpp b42743b1aceab511f8e4dbef9f321e986e34f4ad
src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0
src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
Diff: https://reviews.apache.org/r/55455/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 55455: Moved `HealthChecker` into "checks" folder
and namespace.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55455/
-----------------------------------------------------------
(Updated Jan. 19, 2017, 5:40 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/health-checks.md 890e2983c2269d4b5fdbf70d9d19bec2b63cb2f1
src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4
src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db
src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7
src/health-check/CMakeLists.txt
src/health-check/health_checker.hpp 59831b12b99b87c15a51a7aa6c43b23be2c42a26
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
src/health-check/tcp_connect.cpp
src/launcher/default_executor.cpp 57e4799e750f8f5352a9fec58af40efe432ea865
src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0
src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
Diff: https://reviews.apache.org/r/55455/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 55455: Moved `HealthChecker` into "checks" folder
and namespace.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55455/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 10 a.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Changes
-------
Fixed includes order.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/health-checks.md 890e2983c2269d4b5fdbf70d9d19bec2b63cb2f1
src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4
src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db
src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7
src/health-check/CMakeLists.txt
src/health-check/health_checker.hpp 59831b12b99b87c15a51a7aa6c43b23be2c42a26
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
src/health-check/tcp_connect.cpp
src/launcher/default_executor.cpp 57e4799e750f8f5352a9fec58af40efe432ea865
src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0
src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
Diff: https://reviews.apache.org/r/55455/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 55455: Moved `HealthChecker` into "checks" folder
and namespace.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55455/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 9:31 a.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/health-checks.md 890e2983c2269d4b5fdbf70d9d19bec2b63cb2f1
src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4
src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db
src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7
src/health-check/CMakeLists.txt
src/health-check/health_checker.hpp 59831b12b99b87c15a51a7aa6c43b23be2c42a26
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
src/health-check/tcp_connect.cpp
src/launcher/default_executor.cpp 57e4799e750f8f5352a9fec58af40efe432ea865
src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0
src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4
Diff: https://reviews.apache.org/r/55455/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov