You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/02/14 19:35:12 UTC
[jira] Created: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Remove the deprecated INode.getAbsoluteName()
---------------------------------------------
Key: HADOOP-2831
URL: https://issues.apache.org/jira/browse/HADOOP-2831
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
Fix For: 0.17.0
The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-2831:
------------------------------------
Hadoop Flags: [Incompatible change]
Noted as incompatible in changes.txt
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583880#action_12583880 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-2831:
------------------------------------------------
+1 codes look good.
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584042#action_12584042 ]
lohit vijayarenu commented on HADOOP-2831:
------------------------------------------
This patch removes deprecated API does so testcases were not included.
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lohit vijayarenu updated HADOOP-2831:
-------------------------------------
Status: Patch Available (was: Open)
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lohit vijayarenu updated HADOOP-2831:
-------------------------------------
Release Note: Removes deprecated method INode#getAbsoluteName()
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lohit vijayarenu updated HADOOP-2831:
-------------------------------------
Status: Open (was: Patch Available)
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler reassigned HADOOP-2831:
---------------------------------------
Assignee: lohit vijayarenu
If deprecated in 0.15, then remove for 0.17.
Otherwise set the fix version for this issue to 0.18.
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lohit vijayarenu updated HADOOP-2831:
-------------------------------------
Status: Patch Available (was: Open)
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584345#action_12584345 ]
Chris Douglas commented on HADOOP-2831:
---------------------------------------
Would it make sense to remove o.a.h.dfs.BlockCrcUpgrade.INodeMapEntry::getAbsoluteName() as well?
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lohit vijayarenu updated HADOOP-2831:
-------------------------------------
Attachment: HADOOP-2831-1.patch
Attaching patch which deprecates the API. There is one another place where this is use in log message. I changed it to use fileName already present instead of absolutePath()
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-2831:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Spoke with Lohit offline, cleared up my confusion.
I just committed this. Thanks, Lohit!
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lohit vijayarenu updated HADOOP-2831:
-------------------------------------
Attachment: (was: HADOOP-2831-1-2.patch)
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lohit vijayarenu updated HADOOP-2831:
-------------------------------------
Attachment: HADOOP-2831-2.patch
was getting rid of wrong getAbsoluteName(). Reverting that. Thanks Nicolas.
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583884#action_12583884 ]
Hadoop QA commented on HADOOP-2831:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378977/HADOOP-2831-2.patch
against trunk revision 619744.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
patch -1. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2105/console
This message is automatically generated.
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584040#action_12584040 ]
Hadoop QA commented on HADOOP-2831:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378977/HADOOP-2831-2.patch
against trunk revision 643282.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/console
This message is automatically generated.
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1.patch, HADOOP-2831-2.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2831) Remove the deprecated
INode.getAbsoluteName()
Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lohit vijayarenu updated HADOOP-2831:
-------------------------------------
Attachment: HADOOP-2831-1-2.patch
> Remove the deprecated INode.getAbsoluteName()
> ---------------------------------------------
>
> Key: HADOOP-2831
> URL: https://issues.apache.org/jira/browse/HADOOP-2831
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: lohit vijayarenu
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: HADOOP-2831-1-2.patch, HADOOP-2831-1.patch
>
>
> The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.
> INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.