You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/25 12:27:21 UTC
[GitHub] [incubator-dolphinscheduler] clay4444 opened a new pull request
#1577: refactor zk tree cache
clay4444 opened a new pull request #1577: refactor zk tree cache
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1577
#752 What is the purpose of the pull request
in ZookeeperCachedOperator class, the current implementation is to use a map to store all the treecache, which may be problematic. The correct method is to use a treecache to monitor
zk /${~ scheduler} All events under the root path, which is responsible for forwarding to the subclass, and the subclass uses the path to get the events it cares about
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1577:
refactor zk tree cache
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1577: refactor zk tree cache
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1577#issuecomment-568894539
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577?src=pr&el=h1) Report
> Merging [#1577](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/026fdd9e1c2fab944776c6cc09716d0b5b185baa?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1577 +/- ##
========================================
+ Coverage 7.58% 7.59% +<.01%
========================================
Files 277 276 -1
Lines 13743 13739 -4
Branches 2194 2197 +3
========================================
Hits 1043 1043
+ Misses 12631 12627 -4
Partials 69 69
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../dolphinscheduler/common/zk/ZookeeperOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlck9wZXJhdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/server/zk/ZKWorkerClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3prL1pLV29ya2VyQ2xpZW50LmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...inscheduler/common/zk/ZookeeperCachedOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlckNhY2hlZE9wZXJhdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/server/zk/ZKMasterClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3prL1pLTWFzdGVyQ2xpZW50LmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577?src=pr&el=footer). Last update [026fdd9...cc1a5ff](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1577:
refactor zk tree cache
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #1577: refactor zk tree cache
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services