[GitHub] [pinot] snleee commented on a change in pull request #8067: Wire EmptySegmentPruner to routing config

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #8067:
URL: https://github.com/apache/pinot/pull/8067#discussion_r796189579



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/SegmentPrunerFactory.java
##########
@@ -45,11 +46,14 @@ private SegmentPrunerFactory() {
 
   public static List<SegmentPruner> getSegmentPruners(TableConfig tableConfig,
       ZkHelixPropertyStore<ZNRecord> propertyStore) {
-    RoutingConfig routingConfig = tableConfig.getRoutingConfig();
     List<SegmentPruner> segmentPruners = new ArrayList<>();
-    // Always prune out empty segments first
-    segmentPruners.add(new EmptySegmentPruner(tableConfig, propertyStore));
+    boolean needsEmptySegment = TableConfigUtils.needsEmptySegmentPruner(tableConfig);
+    if (needsEmptySegment) {
+      // Always add EmptySegmentPruner if Kinesis consumer is used.

Review comment:
       I think that this comment now needs to be changed
   ```
   Add EmptySegmentPruner if needed
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org