You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/24 07:04:06 UTC
[GitHub] [flink] rmetzger commented on a change in pull request #16261: [FLINK-23045][tests] Harden RunnablesTest by not relying on timeout
rmetzger commented on a change in pull request #16261:
URL: https://github.com/apache/flink/pull/16261#discussion_r657679959
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/util/RunnablesTest.java
##########
@@ -53,9 +55,9 @@ public void testExecutorService_uncaughtExceptionHandler() throws InterruptedExc
() -> {
throw new RuntimeException("foo");
});
- Assert.assertTrue(
- "Expected handler to be called.",
- handlerCalled.await(TIMEOUT_MS, TimeUnit.MILLISECONDS));
+
+ // expect handler to be called
+ handlerCalled.await();
Review comment:
Why did you not apply this to the `testScheduledExecutorService_uncaughtExceptionHandler` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org