You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/04/23 13:45:58 UTC
[GitHub] [commons-dbcp] arturobernalg opened a new pull request #101: DBCP-578 - Use List Instead Of Vector
arturobernalg opened a new pull request #101:
URL: https://github.com/apache/commons-dbcp/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] garydgregory commented on pull request #101: DBCP-578 - Use List Instead Of Vector
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #101:
URL: https://github.com/apache/commons-dbcp/pull/101#issuecomment-851641187
> > Hi @arturobernalg
> > Why? You need a clear explanation of why `Collections.synchronizedList` is better than `Vector` or `CopyOnWriteArrayList`.
> > Can changing this be likely to have ramification beyond what the current tests assert?
> > I plan on cutting a release candidate very soon so this one might have to wait for the next go around.
>
> Hi @garydgregory
> We won using the List interface and all the implementations. We don't lose the synchronized behavior because it create by Collections.synchronizedList.
> And seems logical --> https://stackoverflow.com/a/1386288/4495592
> Maybe I'm wrong.
> TY
Yes, i understand the separation of concerns; but I wondering if it worth looking into synchronization at a higher level, maybe, maybe not. In the meantime, I'll take another look at this in more detail later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] garydgregory commented on pull request #101: DBCP-578 - Use List Instead Of Vector
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #101:
URL: https://github.com/apache/commons-dbcp/pull/101#issuecomment-851543944
Hi @arturobernalg
Why? You need a clear explanation of why `Collections.synchronizedList` is better than `Vector` or `CopyOnWriteArrayList`.
Can changing this be likely to have ramification beyond what the current tests assert?
I plan on cutting a release candidate very soon so this one might have to wait for the next go around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] arturobernalg commented on pull request #101: DBCP-578 - Use List Instead Of Vector
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #101:
URL: https://github.com/apache/commons-dbcp/pull/101#issuecomment-851635811
> Hi @arturobernalg
>
> Why? You need a clear explanation of why `Collections.synchronizedList` is better than `Vector` or `CopyOnWriteArrayList`.
> Can changing this be likely to have ramification beyond what the current tests assert?
> I plan on cutting a release candidate very soon so this one might have to wait for the next go around.
Hi @garydgregory
We won using the List interface and all the implementations. We don't lose the synchronized behavior because it create by Collections.synchronizedList.
And seems logical --> https://stackoverflow.com/a/1386288/4495592
Maybe I'm wrong.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] garydgregory merged pull request #101: DBCP-578 - Use List Instead Of Vector
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #101:
URL: https://github.com/apache/commons-dbcp/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-dbcp] garydgregory edited a comment on pull request #101: DBCP-578 - Use List Instead Of Vector
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #101:
URL: https://github.com/apache/commons-dbcp/pull/101#issuecomment-851641187
> > Hi @arturobernalg
> > Why? You need a clear explanation of why `Collections.synchronizedList` is better than `Vector` or `CopyOnWriteArrayList`.
> > Can changing this be likely to have ramification beyond what the current tests assert?
> > I plan on cutting a release candidate very soon so this one might have to wait for the next go around.
>
> Hi @garydgregory
> We won using the List interface and all the implementations. We don't lose the synchronized behavior because it create by Collections.synchronizedList.
> And seems logical --> https://stackoverflow.com/a/1386288/4495592
> Maybe I'm wrong.
> TY
Yes, i understand the separation of concerns; but I am wondering if it worth looking into synchronization at a higher level, maybe, maybe not. In the meantime, I'll take another look at this in more detail later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org