You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/29 14:15:25 UTC

[GitHub] [incubator-kyuubi] pan3793 opened a new pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from test deps

pan3793 opened a new pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856


   ### _Why are the changes needed?_
   
   The pervious PR did not handle the test-jars
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] turboFei closed pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from spark-hive and fix detect deps change workflow

Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from test deps

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856#issuecomment-1026945299


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1856](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a085394) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/8b389f27fd4a4c2648c0c6b73daa6e0461d013d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b389f2) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head a085394 differs from pull request most recent head 2785acf. Consider uploading reports for the commit 2785acf to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1856   +/-   ##
   =========================================
     Coverage     59.70%   59.70%           
   - Complexity      268      269    +1     
   =========================================
     Files           282      282           
     Lines         13978    13978           
     Branches       1781     1781           
   =========================================
   + Hits           8345     8346    +1     
     Misses         4924     4924           
   + Partials        709      708    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.88% <0.00%> (+1.17%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec719b8...2785acf](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] turboFei commented on pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from test deps

Posted by GitBox <gi...@apache.org>.
turboFei commented on pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856#issuecomment-1025080799


   you can rebase on #1854 if it is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] turboFei commented on pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from test deps

Posted by GitBox <gi...@apache.org>.
turboFei commented on pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856#issuecomment-1025079597


   > ```
   > Warning:  [Warn] /home/runner/work/incubator-kyuubi/incubator-kyuubi/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiCommands.java:483: Character(char) in java.lang.Character has been deprecated
   > Warning:  Scalastyle:check is skipped as scalastyle.skip=true
   > Error: ] : Symbol 'type org.apache.log4j.AppenderSkeleton' is missing from the classpath.
   > ```
   
   let me try to revert the change for kyuubi-hive-beeline module


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] turboFei commented on pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from test deps

Posted by GitBox <gi...@apache.org>.
turboFei commented on pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856#issuecomment-1026883181


   ```
   Dependency List Changed Detected: 
   78a79 > log4j/1.2.17//log4j-1.2.17.jar 96a98 > slf4j-log4j12/1.7.30//slf4j-log4j12-1.7.30.jar
   > log4j/1.2.17//log4j-1.2.17.jar
   96a98
   > slf4j-log4j12/1.7.30//slf4j-log4j12-1.7.30.jar ]]
   To update the dependency file, run './build/dependency.sh --replace'.
   + echo 'Dependency List Changed Detected: '
   + echo 78a79 '>' log4j/1.2.17//log4j-1.2.17.jar 96a98 '>' slf4j-log4j12/1.7.30//slf4j-log4j12-1.7.30.jar
   + echo 'To update the dependency file, run '\''./build/dependency.sh --replace'\''.'
   + exit 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from test deps

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856#issuecomment-1026945299


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1856](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a085394) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/8b389f27fd4a4c2648c0c6b73daa6e0461d013d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b389f2) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head a085394 differs from pull request most recent head 58affcb. Consider uploading reports for the commit 58affcb to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1856   +/-   ##
   =========================================
     Coverage     59.70%   59.70%           
   - Complexity      268      269    +1     
   =========================================
     Files           282      282           
     Lines         13978    13978           
     Branches       1781     1781           
   =========================================
   + Hits           8345     8346    +1     
     Misses         4924     4924           
   + Partials        709      708    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.88% <0.00%> (+1.17%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec719b8...58affcb](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from spark-hive and fix detect deps change workflow

Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856#issuecomment-1026979110


   @turboFei The detect dependencyList changes workflow failed because of cache issue, I updated and solved it, please take a look again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from test deps

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856#issuecomment-1026945299


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1856](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (301acb6) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/ec719b82deebc34c4554bc4483a98fda7e4514c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec719b8) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 301acb6 differs from pull request most recent head 2785acf. Consider uploading reports for the commit 2785acf to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1856   +/-   ##
   =========================================
     Coverage     59.70%   59.70%           
     Complexity      268      268           
   =========================================
     Files           282      282           
     Lines         13978    13978           
     Branches       1781     1781           
   =========================================
     Hits           8346     8346           
     Misses         4924     4924           
     Partials        708      708           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec719b8...2785acf](https://codecov.io/gh/apache/incubator-kyuubi/pull/1856?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] turboFei commented on pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from spark-hive and fix detect deps change workflow

Posted by GitBox <gi...@apache.org>.
turboFei commented on pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856#issuecomment-1027002143


   thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-kyuubi] turboFei commented on pull request #1856: [KYUUBI #1769][FOLLOWUP] Exclude log4j 12 deps from test deps

Posted by GitBox <gi...@apache.org>.
turboFei commented on pull request #1856:
URL: https://github.com/apache/incubator-kyuubi/pull/1856#issuecomment-1025045786


   ```
   Warning:  [Warn] /home/runner/work/incubator-kyuubi/incubator-kyuubi/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiCommands.java:483: Character(char) in java.lang.Character has been deprecated
   Warning:  Scalastyle:check is skipped as scalastyle.skip=true
   Error: ] : Symbol 'type org.apache.log4j.AppenderSkeleton' is missing from the classpath.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org