You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/01 13:26:45 UTC

[GitHub] [apisix-docker] gxthrj opened a new pull request #124: fix: compile error with openssl

gxthrj opened a new pull request #124:
URL: https://github.com/apache/apisix-docker/pull/124


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-docker] tokers commented on a change in pull request #124: fix: compile error with openssl

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #124:
URL: https://github.com/apache/apisix-docker/pull/124#discussion_r567825806



##########
File path: alpine-dev/Dockerfile
##########
@@ -5,13 +5,15 @@ FROM openresty/openresty:alpine-fat AS production-stage
 ARG ENABLE_PROXY
 RUN set -x \
     && (test "${ENABLE_PROXY}" != "true" || /bin/sed -i 's,http://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g' /etc/apk/repositories) \
-    && apk add --no-cache --virtual .builddeps \
+    && apk add --no-cache --virtual .builddeps openssl-dev \

Review comment:
       It should be `openresty-openssl-dev`.

##########
File path: alpine/Dockerfile
##########
@@ -8,13 +8,15 @@ LABEL apisix_version="${APISIX_VERSION}"
 ARG ENABLE_PROXY
 RUN set -x \
     && (test "${ENABLE_PROXY}" != "true" || /bin/sed -i 's,http://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g' /etc/apk/repositories) \
-    && apk add --no-cache --virtual .builddeps \
+    && apk add --no-cache --virtual .builddeps openssl-dev \

Review comment:
       Ditto.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-docker] gxthrj commented on a change in pull request #124: fix: compile error with openssl

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #124:
URL: https://github.com/apache/apisix-docker/pull/124#discussion_r567827358



##########
File path: alpine-dev/Dockerfile
##########
@@ -5,13 +5,15 @@ FROM openresty/openresty:alpine-fat AS production-stage
 ARG ENABLE_PROXY
 RUN set -x \
     && (test "${ENABLE_PROXY}" != "true" || /bin/sed -i 's,http://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g' /etc/apk/repositories) \
-    && apk add --no-cache --virtual .builddeps \
+    && apk add --no-cache --virtual .builddeps openssl-dev \

Review comment:
       `openresty-openssl-dev` can not be found will occur an error.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-docker] gxthrj commented on pull request #124: fix: compile error with openssl

Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #124:
URL: https://github.com/apache/apisix-docker/pull/124#issuecomment-770859816


   Close this PR, Repeated with #123 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-docker] gxthrj closed pull request #124: fix: compile error with openssl

Posted by GitBox <gi...@apache.org>.
gxthrj closed pull request #124:
URL: https://github.com/apache/apisix-docker/pull/124


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-docker] tokers commented on a change in pull request #124: fix: compile error with openssl

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #124:
URL: https://github.com/apache/apisix-docker/pull/124#discussion_r567827995



##########
File path: alpine-dev/Dockerfile
##########
@@ -5,13 +5,15 @@ FROM openresty/openresty:alpine-fat AS production-stage
 ARG ENABLE_PROXY
 RUN set -x \
     && (test "${ENABLE_PROXY}" != "true" || /bin/sed -i 's,http://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g' /etc/apk/repositories) \
-    && apk add --no-cache --virtual .builddeps \
+    && apk add --no-cache --virtual .builddeps openssl-dev \

Review comment:
       See http://openresty.org/en/linux-packages.html#ubuntu for the details.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org