You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2018/03/15 06:32:30 UTC
[GitHub] flink pull request #5702: [FLINK-8771] Upgrade scalastyle to 1.0.0
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5702
[FLINK-8771] Upgrade scalastyle to 1.0.0
## What is the purpose of the change
Upgrade scalastyle from 0.8.0 to 1.0.0
## Brief change log
- Upgrade scalastyle from 0.8.0 to 1.0.0
- Fixed some license style issues along the way, because scalalstyle 1.0.0 detected those as errors
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
none
## Documentation
none
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-8771
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5702.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5702
----
commit 97160a70ae64e90cc101512ab0fb4c08ba79d924
Author: Bowen Li <bo...@...>
Date: 2018-03-15T00:26:18Z
[FLINK-8771] Upgrade scalastyle to 1.0.0
----
---
[GitHub] flink issue #5702: [FLINK-8771] [Checkstyle/Scalastyle] [Build System] Upgra...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5702
merging
---
[GitHub] flink issue #5702: [FLINK-8771] [Build System] [Checkstyle/Scalastyle] Upgra...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5702
Hi @zentol , can you take a look at this PR?
---
[GitHub] flink issue #5702: [FLINK-8771] [Build System] [Checkstyle/Scalastyle] Upgra...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5702
cc @zentol
---
[GitHub] flink pull request #5702: [FLINK-8771] [Checkstyle/Scalastyle] [Build System...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5702
---