You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tz...@apache.org on 2019/01/15 09:17:41 UTC
[flink] branch master updated (1325599 -> e7b02b4)
This is an automated email from the ASF dual-hosted git repository.
tzulitai pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from 1325599 [hotfix][docs][table] Fix more typos in time attributes doc
new e5e6274 [hotfix] [docs] Fix typo in Table SQL doc
new baea9a3 [hotfix] [datastream] Remove irrelevant comments and fix typo in SourceStreamTask
new e7b02b4 [hotfix] [fs] Add clock as an argument in Javadocs
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
docs/dev/table/sourceSinks.md | 2 +-
docs/dev/table/sql.md | 2 +-
.../org/apache/flink/streaming/connectors/fs/bucketing/Bucketer.java | 1 +
.../org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java | 4 +---
4 files changed, 4 insertions(+), 5 deletions(-)
[flink] 01/03: [hotfix] [docs] Fix typo in Table SQL doc
Posted by tz...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tzulitai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit e5e6274f962497e3c3594d4a6f5fe686bb06587e
Author: JaryZhen <ja...@JZ.local>
AuthorDate: Tue Jan 15 12:52:40 2019 +0800
[hotfix] [docs] Fix typo in Table SQL doc
This closes #7491.
---
docs/dev/table/sourceSinks.md | 2 +-
docs/dev/table/sql.md | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/dev/table/sourceSinks.md b/docs/dev/table/sourceSinks.md
index ab58a72..483ef20 100644
--- a/docs/dev/table/sourceSinks.md
+++ b/docs/dev/table/sourceSinks.md
@@ -205,7 +205,7 @@ DefinedRowtimeAttributes {
* `getRowtimeAttributeDescriptors()`: Returns a list of `RowtimeAttributeDescriptor`. A `RowtimeAttributeDescriptor` describes a rowtime attribute with the following properties:
* `attributeName`: The name of the rowtime attribute in the table schema. The field must be defined with type `Types.SQL_TIMESTAMP`.
- * `timestampExtractor`: The timestamp extractor extracts the timestamp from a record with the return type. For example, it can convert convert a Long field into a timestamp or parse a String-encoded timestamp. Flink comes with a set of built-in `TimestampExtractor` implementation for common use cases. It is also possible to provide a custom implementation.
+ * `timestampExtractor`: The timestamp extractor extracts the timestamp from a record with the return type. For example, it can convert a Long field into a timestamp or parse a String-encoded timestamp. Flink comes with a set of built-in `TimestampExtractor` implementation for common use cases. It is also possible to provide a custom implementation.
* `watermarkStrategy`: The watermark strategy defines how watermarks are generated for the rowtime attribute. Flink comes with a set of built-in `WatermarkStrategy` implementations for common use cases. It is also possible to provide a custom implementation.
<span class="label label-danger">Attention</span> Although the `getRowtimeAttributeDescriptors()` method returns a list of descriptors, only a single rowtime attribute is support at the moment. We plan to remove this restriction in the future and support tables with more than one rowtime attribute.
diff --git a/docs/dev/table/sql.md b/docs/dev/table/sql.md
index 1e7ef83..14df441 100644
--- a/docs/dev/table/sql.md
+++ b/docs/dev/table/sql.md
@@ -93,7 +93,7 @@ val result2 = tableEnv.sqlQuery(
// SQL update with a registered table
// create and register a TableSink
-TableSink csvSink = new CsvTableSink("/path/to/file", ...)
+val csvSink: CsvTableSink = new CsvTableSink("/path/to/file", ...)
val fieldNames: Array[String] = Array("product", "amount")
val fieldTypes: Array[TypeInformation[_]] = Array(Types.STRING, Types.INT)
tableEnv.registerTableSink("RubberOrders", fieldNames, fieldTypes, csvSink)
[flink] 02/03: [hotfix] [datastream] Remove irrelevant comments and
fix typo in SourceStreamTask
Posted by tz...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tzulitai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit baea9a35a9dc209229fae043991b394c141b1265
Author: leesf <49...@qq.com>
AuthorDate: Mon Jan 14 23:24:56 2019 +0800
[hotfix] [datastream] Remove irrelevant comments and fix typo in SourceStreamTask
This closes #7485.
---
.../org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
index 644d57c..8bd3534 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
@@ -53,10 +53,8 @@ public class SourceStreamTask<OUT, SRC extends SourceFunction<OUT>, OP extends S
@Override
protected void init() {
- // does not hold any resources, so no initialization needed
-
// we check if the source is actually inducing the checkpoints, rather
- // than the trigger ch
+ // than the trigger
SourceFunction<?> source = headOperator.getUserFunction();
if (source instanceof ExternallyInducedSource) {
externallyInducedCheckpoints = true;
[flink] 03/03: [hotfix] [fs] Add clock as an argument in Javadocs
Posted by tz...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tzulitai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit e7b02b42364563dfa20c8189da50d1a0a7529f4a
Author: Fokko Driesprong <fo...@apache.org>
AuthorDate: Mon Jan 14 14:54:32 2019 +0100
[hotfix] [fs] Add clock as an argument in Javadocs
The clock parameter is missing in the docstring.
This closes #7484.
---
.../org/apache/flink/streaming/connectors/fs/bucketing/Bucketer.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/Bucketer.java b/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/Bucketer.java
index f2eebf3..e712b2e 100644
--- a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/Bucketer.java
+++ b/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/Bucketer.java
@@ -38,6 +38,7 @@ public interface Bucketer<T> extends Serializable {
/**
* Returns the {@link Path} of a bucket file.
*
+ * @param clock The current system time in milliseconds.
* @param basePath The base path containing all the buckets.
* @param element The current element being processed.
*