(incubator-uniffle) branch master updated: [MINOR] refactor: Check debug enabled (#1793)

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 5ba2df86e [MINOR] refactor: Check debug enabled (#1793)
5ba2df86e is described below

commit 5ba2df86e4832e630e34b28199f2776095f9fbcb
Author: Zhen Wang <64...@qq.com>
AuthorDate: Sun Jun 16 00:18:22 2024 +0800

    [MINOR] refactor: Check debug enabled (#1793)
    
    ### What changes were proposed in this pull request?
    
    Address https://github.com/apache/incubator-uniffle/pull/1789#discussion_r1639312935
    
    ### Why are the changes needed?
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    minor fix
---
 .../org/apache/spark/shuffle/writer/BufferManagerOptions.java | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/BufferManagerOptions.java b/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/BufferManagerOptions.java
index 18938c610..839e684a9 100644
--- a/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/BufferManagerOptions.java
+++ b/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/BufferManagerOptions.java
@@ -64,10 +64,13 @@ public class BufferManagerOptions {
             RssSparkConfig.RSS_WRITER_PRE_ALLOCATED_BUFFER_SIZE.defaultValue().get());
     requireMemoryInterval = sparkConf.get(RssSparkConfig.RSS_WRITER_REQUIRE_MEMORY_INTERVAL);
     requireMemoryRetryMax = sparkConf.get(RssSparkConfig.RSS_WRITER_REQUIRE_MEMORY_RETRY_MAX);
-    LOG.debug(RssSparkConfig.RSS_WRITER_BUFFER_SIZE.key() + "=" + bufferSize);
-    LOG.debug(RssSparkConfig.RSS_WRITER_BUFFER_SPILL_SIZE.key() + "=" + bufferSpillThreshold);
-    LOG.debug(
-        RssSparkConfig.RSS_WRITER_PRE_ALLOCATED_BUFFER_SIZE.key() + "=" + preAllocatedBufferSize);
+    if (LOG.isDebugEnabled()) {
+      LOG.debug(
+          "New buffer manager options, bufferSize: {}, bufferSpillThreshold: {}, preAllocatedBufferSize: {}",
+          bufferSize,
+          bufferSpillThreshold,
+          preAllocatedBufferSize);
+    }
     checkBufferSize();
   }