You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by "ChengJie1053 (via GitHub)" <gi...@apache.org> on 2023/08/29 11:03:07 UTC
[GitHub] [linkis] ChengJie1053 opened a new pull request, #4889: Spark k8s operator task Added status acquisition
ChengJie1053 opened a new pull request, #4889:
URL: https://github.com/apache/linkis/pull/4889
Spark k8s operator task Added status acquisition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [linkis] ChengJie1053 commented on a diff in pull request #4889: Spark k8s operator task Added status acquisition
Posted by "ChengJie1053 (via GitHub)" <gi...@apache.org>.
ChengJie1053 commented on code in PR #4889:
URL: https://github.com/apache/linkis/pull/4889#discussion_r1309531885
##########
linkis-engineconn-plugins/spark/src/main/java/org/apache/linkis/engineplugin/spark/client/deployment/KubernetesOperatorClusterDescriptorAdapter.java:
##########
@@ -230,4 +230,16 @@ public static SparkApplication getSparkApplication(String sparkOperatorName, Str
sparkApplication.setMetadata(metadata);
return sparkApplication;
}
+
Review Comment:
Ok, thanks for reviewing the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [linkis] rarexixi commented on a diff in pull request #4889: Spark k8s operator task Added status acquisition
Posted by "rarexixi (via GitHub)" <gi...@apache.org>.
rarexixi commented on code in PR #4889:
URL: https://github.com/apache/linkis/pull/4889#discussion_r1308805022
##########
linkis-engineconn-plugins/spark/src/main/java/org/apache/linkis/engineplugin/spark/client/deployment/KubernetesOperatorClusterDescriptorAdapter.java:
##########
@@ -230,4 +230,16 @@ public static SparkApplication getSparkApplication(String sparkOperatorName, Str
sparkApplication.setMetadata(metadata);
return sparkApplication;
}
+
Review Comment:
1. Modify `getSparkApplicationClient` return value type to `MixedOperation<SparkApplication, SparkApplicationList, Resource<SparkApplication>>`
2. Suggest using the following method to monitor status
```
getSparkApplicationClient(client).inNamespace(this.sparkConfig.getK8sNamespace()).withName(this.sparkConfig.getAppName()).watch(new Watcher<SparkApplication>() {
@Override
public void eventReceived(Action action, SparkApplication sparkApplication) {
// todo get status
}
@Override
public void onClose(WatcherException e) {
}
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [linkis] rarexixi merged pull request #4889: Spark k8s operator task Added status acquisition
Posted by "rarexixi (via GitHub)" <gi...@apache.org>.
rarexixi merged PR #4889:
URL: https://github.com/apache/linkis/pull/4889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org