You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (Jira)" <ji...@apache.org> on 2021/07/27 13:42:00 UTC

[jira] [Commented] (CASSANDRA-15533) Don't allocate unneeded MergeIterator in OnDiskToken#iterator

    [ https://issues.apache.org/jira/browse/CASSANDRA-15533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388062#comment-17388062 ] 

Brandon Williams commented on CASSANDRA-15533:
----------------------------------------------

With 4.0.0 branched this was probably ready for commit, but with it released it should be now?

> Don't allocate unneeded MergeIterator in OnDiskToken#iterator 
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-15533
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15533
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/SASI
>            Reporter: Jordan West
>            Assignee: Jordan West
>            Priority: Normal
>             Fix For: 4.x
>
>
> When reviewing CASSANDRA-15392 it became apparent that the MergeIterator allocated by OnDiskToken#iterator is rarely necessary and so we should avoid allocating one when not needed and skip the MergeIterator pool when needed because its unlikely to be sized correctly. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org