You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/20 10:21:52 UTC
[GitHub] [incubator-doris] zhengshengjun opened a new pull request, #9712: [Bug] fix bug in time_round function
zhengshengjun opened a new pull request, #9712:
URL: https://github.com/apache/incubator-doris/pull/9712
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1141590051
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hello-stephen commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1147460700
hi, I only know `select hour_ceil('1970-01-01 01:00:10') `got `1970-01-01 02:00:00 `,
but `select hour_ceil('1970-01-01 01:00:10', 1, '1970-01-01 00:00:30')`;
what does this sql mean ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1140600096
hi @zhengshengjun you have to format the BE code style.
You can just run `sh build-support/clang-format.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhengshengjun closed pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
zhengshengjun closed pull request #9712: [Bug] fix bug in time_round function
URL: https://github.com/apache/incubator-doris/pull/9712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhengshengjun commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1140219532
@BiteTheDDDDt @dataroaring updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1143208682
@zhengshengjun please format the BE code style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1135459276
Hi, you can add a test to `regression-test` or `be-unit-test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhengshengjun commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1140473804
> Maybe we should fix this function on `vectorized_engine` also? You can execute `set enable_vectorized_engine=true` to open it. The implement is at `be/src/vec/functions/function_datetime_floor_ceil.cpp:162` .
> Maybe we should fix this function on `vectorized_engine` also? You can execute `set enable_vectorized_engine=true` to open it. The implement is at `be/src/vec/functions/function_datetime_floor_ceil.cpp:162` .
do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhengshengjun commented on a diff in pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on code in PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#discussion_r884376882
##########
be/src/vec/functions/function_datetime_floor_ceil.cpp:
##########
@@ -158,6 +158,9 @@ struct FloorCeilImpl {
}
};
+#define FLOOR 0
Review Comment:
good suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhengshengjun commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1140473901
s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1141590028
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1132791605
Are there any wrong cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#discussion_r884375929
##########
be/src/vec/functions/function_datetime_floor_ceil.cpp:
##########
@@ -158,6 +158,9 @@ struct FloorCeilImpl {
}
};
+#define FLOOR 0
Review Comment:
It's better to use `constexpr` to avoid `define`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1140320965
Maybe we should fix this function on `vectorized_engine` also?
You can execute `set enable_vectorized_engine=true` to open it.
The implement is at `be/src/vec/functions/function_datetime_floor_ceil.cpp:162` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhengshengjun commented on pull request #9712: [Bug] fix bug in time_round function
Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1144396163
> @zhengshengjun please format the BE code style
Updated with correct clang-format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org