[GitHub] [jackrabbit-oak] fabriziofortino commented on pull request #961: OAK-10267: make elastic indexes more lenient when fields cannot be converted

["fabriziofortino (via GitHub)" <gi...@apache.org>]

fabriziofortino commented on PR #961:
URL: https://github.com/apache/jackrabbit-oak/pull/961#issuecomment-1576700093

   > Isn't his already handled on oak side? Any specific reason this is again done on ES level?
   > 
   > Reference:
   > 
   > https://github.com/apache/jackrabbit-oak/blob/846fcb4e89055504cb5b340462b1a961bfb0019d/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocumentMaker.java#L166
   
   @tihom88 you are right but we discovered that the segment store does not respect the contract when a String field is converted to a Date. As per Javadoc, when the value cannot be converted. it does fail in the memory and document stores but not in the segment store. This PR is a sort of workaround that adds an extra layer of security in such cases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org