You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/12 08:19:34 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1586: fix: some bugs
LaurenceLiZhixin opened a new pull request #1586:
URL: https://github.com/apache/dubbo-go/pull/1586
- 1. Triple-grpc Error response ：triple 异常回传支持
- 2. Triple-grpc Attachment ：triple 请求和相应attachemnt 支持
- 3. ZK Consumer Registry bug: zk consumer registry node should under /$group/interface/consumers/
- 4. ZK Update event log level every some seconds, info -> debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1586: Fix: some bugs and features for 3.0
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1586:
URL: https://github.com/apache/dubbo-go/pull/1586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1586: Fix: some bugs and features for 3.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1586:
URL: https://github.com/apache/dubbo-go/pull/1586#issuecomment-966923738
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1586?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1586](https://codecov.io/gh/apache/dubbo-go/pull/1586?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec64ec0) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/3182c7ad78e4bd46bbbc1f6652313f395bee88d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3182c7a) will **decrease** coverage by `0.61%`.
> The diff coverage is `18.75%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1586 +/- ##
==========================================
- Coverage 41.76% 41.15% -0.62%
==========================================
Files 258 250 -8
Lines 15131 14277 -854
==========================================
- Hits 6320 5875 -445
+ Misses 8078 7718 -360
+ Partials 733 684 -49
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9saXN0ZW5lci5nbw==) | `50.00% <ø> (ø)` | |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `68.26% <0.00%> (+2.52%)` | :arrow_up: |
| [registry/base\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvYmFzZV9yZWdpc3RyeS5nbw==) | `1.27% <0.00%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `76.11% <20.00%> (-5.19%)` | :arrow_down: |
| [protocol/dubbo3/dubbo3\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19pbnZva2VyLmdv) | `60.86% <25.00%> (-4.99%)` | :arrow_down: |
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `28.57% <0.00%> (+1.71%)` | :arrow_up: |
| [filter/gshutdown/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2dzaHV0ZG93bi9maWx0ZXIuZ28=) | `62.16% <0.00%> (+2.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1586?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1586?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3182c7a...ec64ec0](https://codecov.io/gh/apache/dubbo-go/pull/1586?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org