[jira] [Commented] (BEAM-1847) KafkaIO can't specify both max records and max duration.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322213#comment-16322213 ] 

ASF GitHub Bot commented on BEAM-1847:
--------------------------------------

RyanSkraba opened a new pull request #4391: [BEAM-1847]: Consider both max records/time in KafkaIO bounded read.
URL: https://github.com/apache/beam/pull/4391
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [X] Each commit in the pull request should have a meaningful subject line and body.
    - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   
   When using withMaxNumRecords/withMaxReadTime arguments to create a bounded collection from Kafka, there's no reason that *both* stopping conditions (number of records and max time) couldn't be applied.  When either condition is met, the collection is finished.
   
   Currently, setting one stopping condition silently deactivates the other. (

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> KafkaIO can't specify both max records and max duration.
> --------------------------------------------------------
>
>                 Key: BEAM-1847
>                 URL: https://issues.apache.org/jira/browse/BEAM-1847
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>            Reporter: Ryan Skraba
>            Assignee: Ryan Skraba
>            Priority: Minor
>
> Some Beam IOs that expose the ability to turn an unbounded source into a bounded source.  
> For example, KafkaIO uses the underlying Read.from() API to specify the {{withMaxNumRecords}} and/or {{withMaxReadTime}}.  If the former is specified, the latter is silently ignored.  
> I would expect that the first stopping condition to be reached (either max records OR max duration) would stop the source.  
> The underlying implementation {{BoundedReadFromUnboundedSource}} has this logic, but it is not supported -in Read.Unbounded- or the Beam IOs that expose this feature.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)