[GitHub] [airflow] vandonr-amz commented on a diff in pull request #32386: Remove ability to specify arbitrary hook params in AWS RDS trigger

["vandonr-amz (via GitHub)" <gi...@apache.org>]

vandonr-amz commented on code in PR #32386:
URL: https://github.com/apache/airflow/pull/32386#discussion_r1253783399


##########
airflow/providers/amazon/aws/operators/rds.py:
##########
@@ -47,14 +47,14 @@ def __init__(self, *args, aws_conn_id: str = "aws_conn_id", hook_params: dict |
         if hook_params is not None:
             warnings.warn(
                 "The parameter hook_params is deprecated and will be removed. "
+                "Note that it is also incompatible with deferrable mode. "
                 "If you were using it, please get in touch either on airflow slack, "
                 "or by opening a github issue on the project. "
                 "You can mention https://github.com/apache/airflow/pull/32352",
                 AirflowProviderDeprecationWarning,
                 stacklevel=3,  # 2 is in the operator's init, 3 is in the user code creating the operator
             )
-        self.hook_params = hook_params or {}

Review Comment:
   There is a bunch of operators that don't allow passing a region at all, like the sagemaker operators, DMS, etc.
   
   If we want users to be able to pass a region, I think we should add that as an explicit parameter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org