You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mm...@apache.org on 2007/10/12 21:30:12 UTC
svn commit: r584241 - in
/myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp:
UIComponentClassicTagBase.java UIComponentELTag.java UIComponentTag.java
Author: mmarinschek
Date: Fri Oct 12 12:29:32 2007
New Revision: 584241
URL: http://svn.apache.org/viewvc?rev=584241&view=rev
Log:
https://issues.apache.org/jira/browse/MYFACES-1712 (MYFACES-1712): thanks to Thomas Fischer to check back with the spec and provide a better solution
Modified:
myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java
myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentELTag.java
myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentTag.java
Modified: myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java?rev=584241&r1=584240&r2=584241&view=diff
==============================================================================
--- myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java (original)
+++ myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentClassicTagBase.java Fri Oct 12 12:29:32 2007
@@ -1057,7 +1057,6 @@
{
_componentInstance = createComponent(context, id);
_created = true;
- setProperties(_componentInstance);
parent.getFacets().put(facetName, _componentInstance);
}
else
@@ -1101,7 +1100,6 @@
{
_componentInstance = createComponent(context, id);
_created = true;
- setProperties(_componentInstance);
int index = parentTag.getIndexOfNextChildTag();
if (index > parent.getChildCount())
{
Modified: myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentELTag.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentELTag.java?rev=584241&r1=584240&r2=584241&view=diff
==============================================================================
--- myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentELTag.java (original)
+++ myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentELTag.java Fri Oct 12 12:29:32 2007
@@ -97,6 +97,7 @@
}
component.setId(newId);
+ setProperties(component);
return component;
}
Modified: myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentTag.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentTag.java?rev=584241&r1=584240&r2=584241&view=diff
==============================================================================
--- myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentTag.java (original)
+++ myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/UIComponentTag.java Fri Oct 12 12:29:32 2007
@@ -133,9 +133,11 @@
UIComponent component = application.createComponent(componentBinding,
context,
componentType);
+
component.setId(id);
component.setValueBinding("binding", componentBinding);
-
+ setProperties(component);
+
return component;
}
@@ -211,7 +213,7 @@
{
if (getRendererType() != null)
{
- getComponentInstance().setRendererType(getRendererType());
+ component.setRendererType(getRendererType());
}
if (_rendered != null)