[GitHub] [incubator-streampark] Al-assad commented on a diff in pull request #2605: [Improve][kubernetes] Bind Flink's Ingress resources to the lifecycle of Deployment

["Al-assad (via GitHub)" <gi...@apache.org>]

Al-assad commented on code in PR #2605:
URL: https://github.com/apache/incubator-streampark/pull/2605#discussion_r1164012636


##########
streampark-flink/streampark-flink-kubernetes/src/main/scala/org/apache/streampark/flink/kubernetes/IngressController.scala:
##########
@@ -93,16 +115,6 @@ object IngressController extends Logger {
     }
   }
 
-  def deleteIngress(ingressName: String, nameSpace: String): Unit = {

Review Comment:
   Perhaps we should keep the independent deletion method for Ingress and allowing users to manually delete or update Ingress behaviors as needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org