[GitHub] [doris] HappenLee commented on a diff in pull request #15674: [improvement](decimalv3) Java UDF and array type support DECIMALV3

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #15674:
URL: https://github.com/apache/doris/pull/15674#discussion_r1064308852


##########
be/src/vec/functions/function_string.h:
##########
@@ -1940,22 +1940,20 @@ class FunctionMoneyFormat : public IFunction {
         ColumnPtr argument_column = block.get_by_position(arguments[0]).column;
 
         auto result_column = assert_cast<ColumnString*>(res_column.get());
-        auto data_column = assert_cast<const typename Impl::ColumnType*>(argument_column.get());

Review Comment:
   I think the origin way is better? why change the logic, maybe `template MoneyFormatDecimalImpl ` is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org