You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/04/25 18:24:15 UTC
svn commit: r1900277 - in /pdfbox/trunk: fontbox/src/main/java/org/apache/fontbox/encoding/ pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/
Author: tilman
Date: Mon Apr 25 18:24:15 2022
New Revision: 1900277
URL: http://svn.apache.org/viewvc?rev=1900277&view=rev
Log:
PDFBOX-4892: make singleton constructor private / protected, as suggested by Valery Bokov; remove super()
Modified:
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/encoding/MacRomanEncoding.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacOSRomanEncoding.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacRomanEncoding.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/StandardEncoding.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/SymbolEncoding.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/WinAnsiEncoding.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/ZapfDingbatsEncoding.java
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/encoding/MacRomanEncoding.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/encoding/MacRomanEncoding.java?rev=1900277&r1=1900276&r2=1900277&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/encoding/MacRomanEncoding.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/encoding/MacRomanEncoding.java Mon Apr 25 18:24:15 2022
@@ -252,7 +252,7 @@ public class MacRomanEncoding extends En
/**
* Constructor.
*/
- public MacRomanEncoding()
+ private MacRomanEncoding()
{
for (Object[] encodingEntry : MAC_ROMAN_ENCODING_TABLE)
{
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacOSRomanEncoding.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacOSRomanEncoding.java?rev=1900277&r1=1900276&r2=1900277&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacOSRomanEncoding.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacOSRomanEncoding.java Mon Apr 25 18:24:15 2022
@@ -59,8 +59,6 @@ public class MacOSRomanEncoding extends
*/
public MacOSRomanEncoding()
{
- super();
-
// differences and additions to MacRomanEncoding
for (Object[] encodingEntry : MAC_OS_ROMAN_ENCODING_TABLE)
{
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacRomanEncoding.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacRomanEncoding.java?rev=1900277&r1=1900276&r2=1900277&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacRomanEncoding.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/MacRomanEncoding.java Mon Apr 25 18:24:15 2022
@@ -251,7 +251,7 @@ public class MacRomanEncoding extends En
/**
* Constructor.
*/
- public MacRomanEncoding()
+ protected MacRomanEncoding()
{
for (Object[] encodingEntry : MAC_ROMAN_ENCODING_TABLE)
{
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/StandardEncoding.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/StandardEncoding.java?rev=1900277&r1=1900276&r2=1900277&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/StandardEncoding.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/StandardEncoding.java Mon Apr 25 18:24:15 2022
@@ -191,7 +191,7 @@ public class StandardEncoding extends En
/**
* Constructor.
*/
- public StandardEncoding()
+ private StandardEncoding()
{
for (Object[] encodingEntry : STANDARD_ENCODING_TABLE)
{
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/SymbolEncoding.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/SymbolEncoding.java?rev=1900277&r1=1900276&r2=1900277&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/SymbolEncoding.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/SymbolEncoding.java Mon Apr 25 18:24:15 2022
@@ -227,7 +227,7 @@ public class SymbolEncoding extends Enco
/**
* Constructor.
*/
- public SymbolEncoding()
+ private SymbolEncoding()
{
for (Object[] encodingEntry : SYMBOL_ENCODING_TABLE)
{
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/WinAnsiEncoding.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/WinAnsiEncoding.java?rev=1900277&r1=1900276&r2=1900277&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/WinAnsiEncoding.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/WinAnsiEncoding.java Mon Apr 25 18:24:15 2022
@@ -261,7 +261,7 @@ public class WinAnsiEncoding extends Enc
/**
* Constructor.
*/
- public WinAnsiEncoding()
+ private WinAnsiEncoding()
{
for (Object[] encodingEntry : WIN_ANSI_ENCODING_TABLE)
{
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/ZapfDingbatsEncoding.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/ZapfDingbatsEncoding.java?rev=1900277&r1=1900276&r2=1900277&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/ZapfDingbatsEncoding.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/ZapfDingbatsEncoding.java Mon Apr 25 18:24:15 2022
@@ -226,7 +226,7 @@ public class ZapfDingbatsEncoding extend
/**
* Constructor.
*/
- public ZapfDingbatsEncoding()
+ private ZapfDingbatsEncoding()
{
for (Object[] encodingEntry : ZAPFDINGBATS_ENCODING_TABLE)
{