You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vatsrahul1001 (via GitHub)" <gi...@apache.org> on 2026/05/19 17:21:03 UTC
[PR] [v3-2-test] UI: Use local Monaco editor module instead of CDN (#66647) [airflow]
vatsrahul1001 opened a new pull request, #67199:
URL: https://github.com/apache/airflow/pull/67199
Manual backport of #66647 — auto-backport failed due to conflicts in `package.json` and `pnpm-lock.yaml`.
## Conflict resolution
- **`package.json`**: main carried an unrelated bump of `i18next-http-backend` (`^3.0.2` → `^3.0.5`) on top of #66647's `monaco-editor` addition. Kept v3-2-test's `i18next-http-backend@^3.0.2` (scope-of-PR isolation); only added `monaco-editor@^0.52.2`.
- **`pnpm-lock.yaml`**: regenerated from v3-2-test's lockfile + updated `package.json` via `pnpm install --lockfile-only`. Avoids hand-merging transitive resolution drift (react 19.2.4 vs 19.2.5, monaco-editor 0.52.2 vs 0.53.0, etc. that came in via unrelated main commits).
All other files (Monaco component scaffolding, license/notice updates, page integrations) cherry-picked cleanly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-2-test] UI: Use local Monaco editor module instead of CDN (#66647) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #67199:
URL: https://github.com/apache/airflow/pull/67199#discussion_r3268319234
##########
airflow-core/src/airflow/ui/pnpm-lock.yaml:
##########
Review Comment:
`pnpm-lock.yaml` has unexpected changes compared to #66647. Is this intentional? Everything else looks good.
| #67199 | #66647 |
| --- | --- |
| <img width="1929" height="1014" alt="Image" src="https://github.com/user-attachments/assets/405267d4-6f08-4ad3-81d7-0ef7b68d0e33" /> | <img width="1950" height="1023" alt="Image" src="https://github.com/user-attachments/assets/85de2e82-17b2-447e-a9ea-fa9680778c63" /> |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-2-test] UI: Use local Monaco editor module instead of CDN (#66647) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #67199:
URL: https://github.com/apache/airflow/pull/67199#discussion_r3268319234
##########
airflow-core/src/airflow/ui/pnpm-lock.yaml:
##########
Review Comment:
`pnpm-lock.yaml` has unexpected changes compared to #66647. Is this intentional? Everything else looks good.
| #67199 | #66647 |
| --- | --- |
| <img width="1929" height="1014" alt="Image" src="https://github.com/user-attachments/assets/405267d4-6f08-4ad3-81d7-0ef7b68d0e33" /> | <img width="1950" height="1023" alt="Image" src="https://github.com/user-attachments/assets/85de2e82-17b2-447e-a9ea-fa9680778c63" /> |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-2-test] UI: Use local Monaco editor module instead of CDN (#66647) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #67199:
URL: https://github.com/apache/airflow/pull/67199#discussion_r3268319234
##########
airflow-core/src/airflow/ui/pnpm-lock.yaml:
##########
Review Comment:
`pnpm-lock.yaml` has changes compared to #66647. Everything looks good.
| #67199 | #66647 |
| --- | --- |
| <img width="1929" height="1014" alt="Image" src="https://github.com/user-attachments/assets/405267d4-6f08-4ad3-81d7-0ef7b68d0e33" /> | <img width="1950" height="1023" alt="Image" src="https://github.com/user-attachments/assets/85de2e82-17b2-447e-a9ea-fa9680778c63" /> |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-2-test] UI: Use local Monaco editor module instead of CDN (#66647) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #67199:
URL: https://github.com/apache/airflow/pull/67199#discussion_r3268319234
##########
airflow-core/src/airflow/ui/pnpm-lock.yaml:
##########
Review Comment:
`pnpm-lock.yaml` has changes compared to #66647. Is this intentional? Everything else looks good.
| #67199 | #66647 |
| --- | --- |
| <img width="1929" height="1014" alt="Image" src="https://github.com/user-attachments/assets/405267d4-6f08-4ad3-81d7-0ef7b68d0e33" /> | <img width="1950" height="1023" alt="Image" src="https://github.com/user-attachments/assets/85de2e82-17b2-447e-a9ea-fa9680778c63" /> |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-2-test] UI: Use local Monaco editor module instead of CDN (#66647) [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 merged PR #67199:
URL: https://github.com/apache/airflow/pull/67199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-2-test] UI: Use local Monaco editor module instead of CDN (#66647) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #67199:
URL: https://github.com/apache/airflow/pull/67199#discussion_r3268319234
##########
airflow-core/src/airflow/ui/pnpm-lock.yaml:
##########
Review Comment:
`pnpm-lock.yaml` has changes compared to #66647. Is this intentional? Everything else looks good.
| #67199 | #66647 |
| --- | --- |
| <img width="1929" height="1014" alt="Image" src="https://github.com/user-attachments/assets/405267d4-6f08-4ad3-81d7-0ef7b68d0e33" /> | <img width="1950" height="1023" alt="Image" src="https://github.com/user-attachments/assets/85de2e82-17b2-447e-a9ea-fa9680778c63" /> |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org